Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Decouple Brave Ads Sustain/Landed ad notification business logic from AdsImpl #10895

Closed
tmancey opened this issue Jul 24, 2020 · 1 comment
Closed

[Desktop] Decouple Brave Ads Sustain/Landed ad notification business logic from AdsImpl #10895

tmancey opened this issue Jul 24, 2020 · 1 comment
Labels
closed/duplicate Issue has already been reported dev-concern feature/ads OS/Desktop

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 24, 2020

See AdsImpl::StartSustainingAdNotificationInteraction, AdsImpl::SustainAdNotificationInteractionIfNeeded and AdsImpl::IsStillViewingAdNotification
@tmancey tmancey mentioned this issue Jul 29, 2020
Closed
@tmancey tmancey changed the title [Desktop] Decouple Brave Ads Landed ad notification business logic from AdsImpl [Desktop] Decouple Brave Ads Sustain/Landed ad notification business logic from AdsImpl Aug 5, 2020
@tmancey tmancey added the OS/Android Fixes related to Android browser functionality label Aug 5, 2020
@tmancey tmancey changed the title [Desktop] Decouple Brave Ads Sustain/Landed ad notification business logic from AdsImpl Decouple Brave Ads Sustain/Landed ad notification business logic from AdsImpl Aug 5, 2020
@tmancey tmancey removed OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@srirambv srirambv changed the title Decouple Brave Ads Sustain/Landed ad notification business logic from AdsImpl [Desktop] Decouple Brave Ads Sustain/Landed ad notification business logic from AdsImpl Sep 9, 2020
@tmancey tmancey added the closed/duplicate Issue has already been reported label Nov 3, 2020
@tmancey
Copy link
Contributor Author

tmancey commented Nov 3, 2020

Closing issue as resolved by #12486

@tmancey tmancey closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported dev-concern feature/ads OS/Desktop
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmancey