Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Brave Ads business logic from implementation #4318

Closed
tmancey opened this issue May 6, 2019 · 1 comment
Closed

Decouple Brave Ads business logic from implementation #4318

tmancey opened this issue May 6, 2019 · 1 comment
Labels
closed/duplicate Issue has already been reported dev-concern feature/ads QA/No release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented May 6, 2019 •
edited
Loading

Decouple Ads business logic from implementation

I will add a breakdown of tasks here once investigation is complete.
@tmancey tmancey changed the title Decouple Ads business logic from ads_impl Decouple Ads business logic from implementation May 6, 2019
@NejcZdovc NejcZdovc added dev-concern priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels May 6, 2019
@tmancey tmancey changed the title Decouple Ads business logic from implementation Decouple Brave Ads business logic from implementation Jan 20, 2020
@tmancey tmancey removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 20, 2020
@tmancey tmancey mentioned this issue Apr 9, 2020
Closed
@tmancey
Copy link
Contributor Author

tmancey commented Jul 29, 2020

Closing issue as we have raised the following to resolve this issue:

#10554
#10896
#10899
#10895
#10897
#10898

@tmancey tmancey closed this as completed Jul 29, 2020
@tmancey tmancey added closed/duplicate Issue has already been reported QA/No release-notes/exclude labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported dev-concern feature/ads QA/No release-notes/exclude
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @NejcZdovc