-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads not blocked on Cnet.com #1118
Labels
browser-laptop-parity
bug
feature/shields/adblock
Blocking ads & trackers with Shields
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
Milestone
Comments
srirambv
added
bug
feature/shields/adblock
Blocking ads & trackers with Shields
browser-laptop-parity
labels
Sep 13, 2018
Just noticed that b-c is being detected as an ad-blocker on an NYT article (using |
This is working with Brave 0.57.1 |
It's not working fully, it's just only reproducible on some machines. |
bbondy
added a commit
to brave/brave-core
that referenced
this issue
Oct 9, 2018
This also makes it so empty data urls are used by default instead of blocking. Empty image data URLs for images. Fix brave/brave-browser#1430 Fix brave/brave-browser#1118 Fix brave/brave-browser#1428 Fix brave/brave-browser#1362
18 tasks
Verification passed on
Verification Passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
browser-laptop-parity
bug
feature/shields/adblock
Blocking ads & trackers with Shields
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
Description
Ads not blocked on Cnet.com
Steps to Reproduce
Block Ads
Actual result:
Muon
Expected result:
All ads should be blocked by default
Reproduces how often:
Easy
Brave version (chrome://version info)
Reproducible on current release:
No
Website problems only:
Additional Information
cc: @bbondy
The text was updated successfully, but these errors were encountered: