Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Chromium Ads setting that conflicts with Brave ad blocking #1119

Closed
mbacchi opened this issue Sep 13, 2018 · 1 comment · Fixed by brave/brave-core#493
Closed

Hide Chromium Ads setting that conflicts with Brave ad blocking #1119

mbacchi opened this issue Sep 13, 2018 · 1 comment · Fixed by brave/brave-core#493
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields/adblock Blocking ads & trackers with Shields QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@mbacchi
Copy link
Contributor

mbacchi commented Sep 13, 2018

Description

We should disable the confusing Ads setting in Chromium settings that conflicts with Brave ad blocking. I think this is a new setting for Chromium, now is a good time to hide it and avoid using it because it is not as effective as Brave ad blocking. If you open settings and search for ads, it is highlighted under the Privacy and Security -> Content Settings menu. This is the screenshot of where the setting is located:

image

And here is what the toggle looks like:

image

Steps to Reproduce

  1. Open Settings
  2. Search for 'ads'
  3. Go to the Privacy and Security -> Content Settings -> Ads menu

Actual result:

Screenshots above

Expected result:

Reproduces how often:

Always

Brave version (chrome://version info)

Version 0.55.3 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)

Reproducible on current release:

yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? Yes

Additional Information

@mbacchi mbacchi added the feature/shields/adblock Blocking ads & trackers with Shields label Sep 13, 2018
@bbondy bbondy added this to the Releasable builds 0.55.x milestone Sep 13, 2018
@rebron rebron added the feature/global-settings Settings at browser level independent of shields settings label Sep 13, 2018
bbondy added a commit to brave/brave-core that referenced this issue Sep 25, 2018
3rd party cookies is per site and block by default in Brave

We use our own ad block, not Google's adblock-ish, but not really
adblock.

Fix brave/brave-browser#402
Fix brave/brave-browser#1119
@bbondy bbondy added the QA/Yes label Sep 25, 2018
@bbondy bbondy assigned bbondy and unassigned bsclifton Sep 25, 2018
@btlechowski
Copy link

btlechowski commented Sep 27, 2018

Verification passes on

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows 7

Privacy and Security -> Content Settings -> Ads menu is gone
Searching for ads does not find Ads menu (it finds Downloads)
chrome://settings/content/ads redirects to chrome://settings

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Privacy and Security -> Content Settings -> Ads menu is gone
Searching for ads does not find Ads menu (it finds Downloads and Brave shields defaults)
chrome://settings/content/ads redirects to chrome://settings

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields/adblock Blocking ads & trackers with Shields QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants