unnecessary scroll bar on sections of Customize Dashboard popup

[LaurenWags]

Description

Found while testing #10318

There's an unnecessary scroll bar on the Customize Dashboard popup on NTP. It makes sense when "More Cards" is selected, but not for the others (Background Image, Brave Stats, etc).

Note, I'm using Mojave (10.14.6)

Steps to Reproduce

1. Install 1.13.x
2. Open NTP
3. Click on Customize

Actual result:

See scroll bar. Same for Brave Stats, Top Sites, and Clock.

Expected result:

Scroll bar only when needed, ex. on More Cards

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @ryanml @karenkliu @rebron @brave/legacy_qa

[rebron]

Not reproducible in the following build:

Brave	1.15.2 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	macOS Version 10.16 (Build 20A5354i)

and

Brave	1.13.78 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision	4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS	macOS Version 10.16 (Build 20A5354i)

This looks to be Mojave specific and not effecting 10.15 Catalina or 10.16 Big Sur.

[rebron]

Windows:

Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 2004 (Build 19041.450)

[GeetaSarvadnya]

Reproduced Windows 10 x64 - 1.13.79

[btlechowski]

Reproduced on Linux

Brave	1.15.14 Chromium: 85.0.4183.83 (Official Build) nightly (64-bit)
Revision	94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS	Linux

[srirambv]

+1 from @phoogm via #11480 for additional scroll bars

[srirambv]

+1 from https://community.brave.com/t/new-tab-page-scroll-bar/162253

[LaurenWags]

Verified passed with

Brave | 1.16.50 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description.

Confirmed scroll bar is not shown Background Image, Brave Stats, Top Sites, and Clock sections of Customize Dashboard, example:

Confirmed scroll bar is shown on More Cards of Customize Dashboard:

---

Verification passed on

Brave	1.16.50 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	Ubuntu 18.04 LTS

Verified STR from description.

Confirmed scroll bar is not shown Background Image, Brave Stats, Top Sites, and Clock sections of Customize Dashboard, example:

Confirmed scroll bar is shown on More Cards of Customize Dashboard:

---

Verification passed on

Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Verified STR from description.

Confirmed scroll bar is not shown Background Image, Brave Stats, Top Sites, and Clock sections of Customize Dashboard, example:

Confirmed scroll bar is shown on More Cards of Customize Dashboard: