Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CW] Gemini widget button doesn't handle long translations #11445

Closed
LaurenWags opened this issue Aug 26, 2020 · 2 comments · Fixed by brave/brave-core#6708
Closed

[CW] Gemini widget button doesn't handle long translations #11445

LaurenWags opened this issue Aug 26, 2020 · 2 comments · Fixed by brave/brave-core#6708

Comments

@LaurenWags
Copy link
Member

Description

Found while spot checking translations for #11395

When OS is set to German/Germany, the button on the Gemini widget wraps around itself. It seems like maybe this is happening because the translated text on the button is long.

Saw this for German/French, spot checked Norwegian, Finnish, Swedish, Spanish, and Portuguese and did not see this occur, those translations seem a bit shorter.

Steps to Reproduce

  1. Be set to German/Germany or France/French.
  2. Launch 1.13.80
  3. Open NTP

Actual result:

German:
Bildschirmfoto 2020-08-26 um 09 34 10

French:
Capture d’écran 2020-08-26 à 09 47 33

Expected result:

Button should look nice.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.13.80 Chromium: 85.0.4183.83 (Offizieller Build) (64-Bit)
Überarbeitung 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
Betriebssystem macOS Version 10.14.6 (Build 18G3020)
Brave 1.15.11 Chromium: 85.0.4183.83 (Offizieller Build) nightly (64-Bit)
Überarbeitung 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
Betriebssystem macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.12.x n/a, 1.13.x yes
  • Can you reproduce this issue with the beta channel? 1.14.x yes
  • Can you reproduce this issue with the nightly channel? 1.15.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @ryanml @srirambv

@GeetaSarvadnya
Copy link

Reproduced in windows 10 x64 - 1.13.80 for locale Hindi

image

@srirambv srirambv changed the title [Desktop] button on Gemini widget doesn't handle long translations [Desktop][CW] Gemini widget button doesn't handle long translations Aug 26, 2020
@srirambv srirambv added the l10n label Aug 26, 2020
@ryanml ryanml self-assigned this Sep 26, 2020
@ryanml ryanml added this to the 1.16.x - Nightly milestone Sep 26, 2020
ryanml added a commit to brave/brave-core that referenced this issue Sep 26, 2020
deeppandya pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Linux
  • Verified translations are handled correctly on the widget opt-in button
    image

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified translations are handled correctly on the widget opt-in button
    image

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Windows 10 OS Version 1809 (Build 17763.1490)
  • Verified translations are handled correctly on the widget opt-in button
    image

Logged follow-up issue for translations when widget is connected #12154

@rebron rebron changed the title [Desktop][CW] Gemini widget button doesn't handle long translations [CW] Gemini widget button doesn't handle long translations Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment