Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter yclid out of the query string #11578

Closed
fmarier opened this issue Sep 3, 2020 · 4 comments · Fixed by brave/brave-core#6576
Closed

Filter yclid out of the query string #11578

fmarier opened this issue Sep 3, 2020 · 4 comments · Fixed by brave/brave-core#6576

Comments

@fmarier
Copy link
Member

fmarier commented Sep 3, 2020

yclid is a unique click tracker and it is also used by Yahoo! Japan for conversion tracking.

@fmarier fmarier added privacy priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Sep 3, 2020
@fmarier fmarier self-assigned this Sep 3, 2020
fmarier added a commit to brave/brave-core that referenced this issue Sep 9, 2020
@fmarier fmarier added this to the 1.16.x - Nightly milestone Sep 10, 2020
@btlechowski
Copy link

btlechowski commented Sep 30, 2020

Verification passed on

Brave 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

The issues is still reproducible, it seems that the filtering does not work in general. Logged #11924. Based on our process I mark this issue as verified.


Verified using

Brave | 1.16.50 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.14.6 (Build 18G3020)

Using test plan from brave/brave-core#6576 confirmed issue still reproduces.

Screen Shot 2020-10-02 at 3 29 41 PM


Verification passed on


Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)


Used test plan from brave/brave-core#6576 and confirm all the cases are working as expected

@LaurenWags
Copy link
Member

Marking as release-notes/exclude as issue still reproduces, please adjust if necessary cc @rebron

@fmarier
Copy link
Member Author

fmarier commented Oct 2, 2020

Marking as release-notes/exclude as issue still reproduces, please adjust if necessary cc @rebron

I think we can keep it because it's partially working (it does work for cross-site navigations) and the only outstanding issue is tracked in #11924 where I'm working on an uplift for early next week.

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.16.69 x64 build


Verification passed on Samsung Tab A with Android 10 running 1.16.69 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants