Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Follow up to #11057: Implement client ads pacing mechanism #11643

Closed
btlechowski opened this issue Sep 9, 2020 · 2 comments · Fixed by brave/brave-core#6614
Closed

[Desktop] Follow up to #11057: Implement client ads pacing mechanism #11643

btlechowski opened this issue Sep 9, 2020 · 2 comments · Fixed by brave/brave-core#6614
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.14.x - Release #2

Comments

@btlechowski
Copy link

btlechowski commented Sep 9, 2020 •
edited
Loading

Follow up to #11057. Implement client ads pacing mechanism.
The ads are always shown, even when PTR is 0.

Steps to Reproduce

  1. Follow Ads pacing - PTR = 0 from https://github.com/brave/internal/issues/720

Actual result:

Ads are shown

Expected result:

Ads are not shown, because PTR is 0

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.14.79 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS
Brave 1.15.41 Chromium: 85.0.4183.83 (Official Build) nightly (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @AndriusA @tmancey @jsecretan
@tmancey tmancey self-assigned this Sep 10, 2020
@tmancey
Copy link
Contributor

tmancey commented Sep 10, 2020

Please check https://github.com/brave/brave-core/blob/master/vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/eligible_ads_pacing_filter.cc as the value is a double, investigating further

@btlechowski btlechowski mentioned this issue Sep 10, 2020
Closed
@tmancey tmancey mentioned this issue Sep 10, 2020
Merged
32 tasks
@tmancey tmancey added this to the 1.16.x - Nightly milestone Sep 10, 2020
This was referenced Sep 14, 2020
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Sep 22, 2020
Closed
1 task
@btlechowski
Copy link
Author

btlechowski commented Sep 23, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.14.84 Chromium: 85.0.4183.121 (Official Build) (64-bit)
Revision a81aa729a8e1fd413943a339393c82e7b8055ddc-refs/branch-heads/4183@{#1864}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/720

Ads pacing - PTR = 0
Verified ads are not shown

[10967:10967:0923/123241.800110:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 2 eligible ads before pacing
[10967:10967:0923/123241.800220:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d175cdfd-57bf-46c3-9b00-89eed71c6ae5 creative instance id [Roll(0):0.791589]
[10967:10967:0923/123241.800329:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for db2d16ff-d62e-4c1b-9e52-91f2ba727dd6 creative instance id [Roll(0):0.459301]
[10967:10967:0923/123241.800392:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 0 eligible ads after pacing
[10967:10967:0923/123241.800468:VERBOSE1:ads_impl.cc(881)] Ad notification not shown: No eligible ads found

Ads pacing - PTR=0 to PTR=1 through catalog update
Verified ad was shown

[11495:11495:0923/123653.634320:VERBOSE1:ads_impl.cc(818)] Serving ad notification from untargeted category
[11495:11495:0923/123653.636663:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 2 eligible ads before pacing
[11495:11495:0923/123653.636707:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 2 eligible ads after pacing
[11495:11495:0923/123653.636813:VERBOSE2:eligible_ads_priority_filter.cc(81)] 2 eligible ads with a priority of 1
[11495:11495:0923/123653.636930:VERBOSE1:ads_impl.cc(863)] Found 2 eligible ads
[11495:11495:0923/123653.637578:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 6e4115ae-2c20-4b52-8591-cbcf080b4e8c
  parentUuid: f195c609-b4fb-4102-b0bb-0e96292421e5
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  category: untargeted
  title: Campaign 2 CreativeSet 1 Ad 1
  body: Campaign 2 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/
[11495:11495:0923/123653.660702:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 6e4115ae-2c20-4b52-8591-cbcf080b4e8c and db2d16ff-d62e-4c1b-9e52-91f2ba727dd6 creative instance id
[11495:11495:0923/123653.662502:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

Ads pacing - PTR = 0.5 - untargated
50 eligible ads before pacing
21 eligible ads after pacing
21/50 = 0.42 (42%)

[12428:12428:0923/124838.445068:VERBOSE1:ads_impl.cc(818)] Serving ad notification from untargeted category
[12428:12428:0923/124838.492284:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 50 eligible ads before pacing
[12428:12428:0923/124838.496970:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 21 eligible ads after pacing
[12428:12428:0923/124838.497118:VERBOSE2:eligible_ads_priority_filter.cc(81)] 21 eligible ads with a priority of 1
[12428:12428:0923/124838.497323:VERBOSE1:ads_impl.cc(863)] Found 21 eligible ads
[12428:12428:0923/124838.498400:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: fdc72075-f9a0-49ea-944f-2aeca74bd07a
  parentUuid: 9b5c92ed-3aa3-40e1-aede-70aaa76c1594
  creativeInstanceId: 5b7a4cf2-dad9-4871-8e4b-5aacd225b77e
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: untargeted
  title: Campaign 1 CreativeSet 2 Ad 17
  body: Campaign 1 CreativeSet 2 Ad 17
  targetUrl: https://travala.com/

Ads pacing - PTR = 0.5 - Technology & Computing
20 eligible ads before pacing
9 eligible ads after pacing
9/20 = 0.45 (45%)

[12930:12930:0923/125637.658205:VERBOSE1:ads_impl.cc(343)] Browser state changed to unidle
[12930:12930:0923/125637.659821:VERBOSE1:ads_impl.cc(726)] No purchase intent winning categories
[12930:12930:0923/125637.659938:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[12930:12930:0923/125637.660029:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[12930:12930:0923/125637.660095:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[12930:12930:0923/125637.660173:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[12930:12930:0923/125637.661618:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[12930:12930:0923/125637.661660:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[12930:12930:0923/125637.661702:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[12930:12930:0923/125637.661723:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[12930:12930:0923/125637.661758:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[12930:12930:0923/125637.661777:VERBOSE1:ads_impl.cc(788)]   technology & computing
[12930:12930:0923/125637.661809:VERBOSE1:ads_impl.cc(788)]   personal finance
[12930:12930:0923/125637.661829:VERBOSE1:ads_impl.cc(788)]   food & drink
[12930:12930:0923/125637.708187:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 20 eligible ads before pacing
[12930:12930:0923/125637.708299:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 8902146f-7699-4a4d-b935-d5b1d7f94e76 creative instance id [Roll(0.5):0.849252]
[12930:12930:0923/125637.708374:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 7d04db29-b02c-4126-ba8e-65ac4fe61243 creative instance id [Roll(0.5):0.544981]
[12930:12930:0923/125637.708453:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d608b01c-2db7-4073-b946-9a15d70450d7 creative instance id [Roll(0.5):0.987724]
[12930:12930:0923/125637.708517:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for a0d15395-1fc0-4616-83ff-8d3b9e1e7a5a creative instance id [Roll(0.5):0.580915]
[12930:12930:0923/125637.708541:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for b06e28c7-b03c-45d1-9015-bf35b6e2ffc9 creative instance id [Roll(0.5):0.851398]
[12930:12930:0923/125637.708576:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 3833014b-0ea2-428f-ad89-343e51b36284 creative instance id [Roll(0.5):0.697221]
[12930:12930:0923/125637.708597:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 5327c24b-663d-41b9-9138-8460ad3a5a5f creative instance id [Roll(0.5):0.593089]
[12930:12930:0923/125637.708630:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 476dbf31-4372-41cd-a7b1-c5f89a894352 creative instance id [Roll(0.5):0.981932]
[12930:12930:0923/125637.708649:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 52a8a9ac-da74-4ed2-b042-1ff3f6be0f28 creative instance id [Roll(0.5):0.555811]
[12930:12930:0923/125637.708681:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 5b7a4cf2-dad9-4871-8e4b-5aacd225b77e creative instance id [Roll(0.5):0.858505]
[12930:12930:0923/125637.708701:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 8584e37d-7549-4e61-a943-4cd83d26b97a creative instance id [Roll(0.5):0.745081]
[12930:12930:0923/125637.708733:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 9 eligible ads after pacing
[12930:12930:0923/125637.708754:VERBOSE2:eligible_ads_priority_filter.cc(81)] 9 eligible ads with a priority of 1
[12930:12930:0923/125637.708789:VERBOSE1:ads_impl.cc(863)] Found 9 eligible ads
[12930:12930:0923/125637.711481:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: e62ff3bd-29af-48b3-8e65-9ade4656e2b4
  parentUuid: 7b4c0968-4c5b-42c1-ad22-56671aa16891
  creativeInstanceId: bfe0149e-7aa8-4a55-86bc-294e4913f24a
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: technology & computing
  title: Campaign 1 CreativeSet 2 Ad 11
  body: Campaign 1 CreativeSet 2 Ad 11
  targetUrl: https://travala.com/

Verified passed with

Brave	1.14.84 Chromium: 85.0.4183.121 (Official Build) (64-bit)
Revision	a81aa729a8e1fd413943a339393c82e7b8055ddc-refs/branch-heads/4183@{#1864}
OS	macOS Version 10.14.6 (Build 18G3020)

Ads pacing - PTR = 0

[601:775:0923/075557.982128:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 2 eligible ads before pacing
[601:775:0923/075557.982201:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d175cdfd-57bf-46c3-9b00-89eed71c6ae5 creative instance id [Roll(0):0.0674052]
[601:775:0923/075557.982239:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for db2d16ff-d62e-4c1b-9e52-91f2ba727dd6 creative instance id [Roll(0):0.0530994]
[601:775:0923/075557.982274:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 0 eligible ads after pacing
[601:775:0923/075557.982309:VERBOSE1:ads_impl.cc(881)] Ad notification not shown: No eligible ads found

Ads pacing - PTR=0 to PTR=1 through catalog update

[689:775:0923/075836.178890:VERBOSE1:ads_impl.cc(818)] Serving ad notification from untargeted category
[689:775:0923/075836.181818:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 2 eligible ads before pacing
[689:775:0923/075836.181888:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 2 eligible ads after pacing
[689:775:0923/075836.181929:VERBOSE2:eligible_ads_priority_filter.cc(81)] 2 eligible ads with a priority of 1
[689:775:0923/075836.181965:VERBOSE1:ads_impl.cc(863)] Found 2 eligible ads
[689:775:0923/075836.182197:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 814c635d-7f82-4010-a36c-5589ad8f146a
  parentUuid: 5e77fc96-ca76-417d-824f-1e791a000916
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  category: untargeted
  title: Campaign 2 CreativeSet 1 Ad 1
  body: Campaign 2 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/
[689:775:0923/075836.182854:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid 814c635d-7f82-4010-a36c-5589ad8f146a in 120 seconds
[689:775:0923/075836.183035:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 814c635d-7f82-4010-a36c-5589ad8f146a and db2d16ff-d62e-4c1b-9e52-91f2ba727dd6 creative instance id
[689:775:0923/075836.183156:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: db2d16ff-d62e-4c1b-9e52-91f2ba727dd6
  creativeSetId: 7be431a0-c6e4-4ca6-bcac-672e77294b7d
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

Ads pacing - PTR = 0.5 - untargated

50 eligible ads before pacing
23 eligible ads after pacing
23/50 = 0.46 (46%)

[710:775:0923/080312.151783:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 50 eligible ads before pacing
[710:775:0923/080312.151848:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 307a7ac4-29f1-483e-9257-ce033e3b5e51 creative instance id [Roll(0.5):0.816398]
[710:775:0923/080312.151884:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for ad328ff9-bac9-4772-af06-a7fdd122107f creative instance id [Roll(0.5):0.702146]
[710:775:0923/080312.151919:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for e70ecd0d-441c-4a34-9042-b91e8e168b4e creative instance id [Roll(0.5):0.612046]
[710:775:0923/080312.151951:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 221d036d-a815-42d2-944a-d8e894804b4f creative instance id [Roll(0.5):0.81263]
[710:775:0923/080312.151981:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 196d452e-a1a5-40a6-9d72-9dff6dfe4267 creative instance id [Roll(0.5):0.889469]
[710:775:0923/080312.152011:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for a0d15395-1fc0-4616-83ff-8d3b9e1e7a5a creative instance id [Roll(0.5):0.56504]
[710:775:0923/080312.152040:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 20f4a3ed-2187-43d0-b13c-c06422fccf2b creative instance id [Roll(0.5):0.974075]
[710:775:0923/080312.152073:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for b06e28c7-b03c-45d1-9015-bf35b6e2ffc9 creative instance id [Roll(0.5):0.51286]
[710:775:0923/080312.152114:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 5a470e78-c2d1-4827-a8ce-217f4f494619 creative instance id [Roll(0.5):0.647537]
[710:775:0923/080312.152145:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 7c644da6-051a-473f-9bac-bff887540953 creative instance id [Roll(0.5):0.981208]
[710:775:0923/080312.152175:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 5327c24b-663d-41b9-9138-8460ad3a5a5f creative instance id [Roll(0.5):0.952515]
[710:775:0923/080312.152204:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 476dbf31-4372-41cd-a7b1-c5f89a894352 creative instance id [Roll(0.5):0.554608]
[710:775:0923/080312.152234:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 5b7a4cf2-dad9-4871-8e4b-5aacd225b77e creative instance id [Roll(0.5):0.940976]
[710:775:0923/080312.152263:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 8584e37d-7549-4e61-a943-4cd83d26b97a creative instance id [Roll(0.5):0.7376]
[710:775:0923/080312.152291:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 76eb5134-4334-448a-ab04-4b64ec88f138 creative instance id [Roll(0.5):0.563351]
[710:775:0923/080312.152320:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 60348a2f-01a1-42fd-b858-df46ca49ccc6 creative instance id [Roll(0.5):0.764217]
[710:775:0923/080312.152352:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 90031a84-ef06-4e4c-85cf-2bb59ab78ab1 creative instance id [Roll(0.5):0.761211]
[710:775:0923/080312.152383:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for ec8b6251-413d-4eeb-bd39-7773840a2101 creative instance id [Roll(0.5):0.593876]
[710:775:0923/080312.152430:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 269767c1-c6e8-4307-b1d2-25d35445c976 creative instance id [Roll(0.5):0.568092]
[710:775:0923/080312.152463:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 70846bb8-9969-49b3-b5e7-e98337762f6b creative instance id [Roll(0.5):0.839328]
[710:775:0923/080312.152493:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for ed8bf723-1346-48ce-8635-5d86b7b4ebf1 creative instance id [Roll(0.5):0.501538]
[710:775:0923/080312.152521:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 44e7eb81-595d-482d-a405-df4caa9a5584 creative instance id [Roll(0.5):0.732849]
[710:775:0923/080312.152551:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 465e08ad-03be-42ee-902a-dc88688aa2cb creative instance id [Roll(0.5):0.568414]
[710:775:0923/080312.152579:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for b218f98c-f3be-453e-a6f4-212510d2818f creative instance id [Roll(0.5):0.592033]
[710:775:0923/080312.152607:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 632b8b68-f6d6-4e8e-ac04-5a4e462aa9dd creative instance id [Roll(0.5):0.553156]
[710:775:0923/080312.152636:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 20a45748-0f36-4be2-91d8-e699d1f6493c creative instance id [Roll(0.5):0.950737]
[710:775:0923/080312.152664:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 5dc1e0df-c65b-43c6-b241-4cb0240c7fd1 creative instance id [Roll(0.5):0.754107]
[710:775:0923/080312.152691:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 23 eligible ads after pacing
[710:775:0923/080312.152720:VERBOSE2:eligible_ads_priority_filter.cc(81)] 23 eligible ads with a priority of 1
[710:775:0923/080312.152748:VERBOSE1:ads_impl.cc(863)] Found 23 eligible ads
[710:775:0923/080312.152901:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: e9e44d4a-017e-4bd5-b700-baec57021955
  parentUuid: 822363b4-a834-4a65-adf8-480f57de94c7
  creativeInstanceId: 6c73149d-5aa5-482b-8994-dec6094d315e
  creativeSetId: b2054163-9998-4b88-aa0c-9939f55d414a
  category: untargeted
  title: Campaign 1 CreativeSet 3 Ad 15
  body: Campaign 1 CreativeSet 3 Ad 15
  targetUrl: https://travala.com/
[710:775:0923/080312.153426:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid e9e44d4a-017e-4bd5-b700-baec57021955 in 120 seconds
[710:775:0923/080312.153536:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid e9e44d4a-017e-4bd5-b700-baec57021955 and 6c73149d-5aa5-482b-8994-dec6094d315e creative instance id
[710:775:0923/080312.153613:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 6c73149d-5aa5-482b-8994-dec6094d315e
  creativeSetId: b2054163-9998-4b88-aa0c-9939f55d414a
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

Ads pacing - PTR = 0.5 - Technology & Computing

20 eligible ads before pacing
11 eligible ads after pacing
11/20 = 0.55 (55%)

[758:775:0923/080939.975887:VERBOSE1:ads_impl.cc(726)] No purchase intent winning categories
[758:775:0923/080939.975974:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[758:775:0923/080939.976013:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[758:775:0923/080939.976048:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[758:775:0923/080939.976080:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[758:775:0923/080939.977024:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[758:775:0923/080939.977094:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[758:775:0923/080939.977133:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[758:775:0923/080939.977166:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[758:775:0923/080939.977197:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[758:775:0923/080939.977230:VERBOSE1:ads_impl.cc(788)]   technology & computing
[758:775:0923/080939.977260:VERBOSE1:ads_impl.cc(788)]   personal finance
[758:775:0923/080939.977294:VERBOSE1:ads_impl.cc(788)]   food & drink
[758:775:0923/080939.990562:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 20 eligible ads before pacing
[758:775:0923/080939.990621:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 8902146f-7699-4a4d-b935-d5b1d7f94e76 creative instance id [Roll(0.5):0.962114]
[758:775:0923/080939.990656:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for cd8a81fc-5efb-41f1-99b6-945082c3e83a creative instance id [Roll(0.5):0.778257]
[758:775:0923/080939.990689:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 196d452e-a1a5-40a6-9d72-9dff6dfe4267 creative instance id [Roll(0.5):0.878448]
[758:775:0923/080939.990718:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d608b01c-2db7-4073-b946-9a15d70450d7 creative instance id [Roll(0.5):0.609287]
[758:775:0923/080939.990748:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for a0d15395-1fc0-4616-83ff-8d3b9e1e7a5a creative instance id [Roll(0.5):0.775187]
[758:775:0923/080939.990777:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for bfe0149e-7aa8-4a55-86bc-294e4913f24a creative instance id [Roll(0.5):0.697145]
[758:775:0923/080939.990808:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for dcc69e3e-3ba7-43a2-9067-97dbd29c9f61 creative instance id [Roll(0.5):0.625879]
[758:775:0923/080939.990840:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 5327c24b-663d-41b9-9138-8460ad3a5a5f creative instance id [Roll(0.5):0.650983]
[758:775:0923/080939.990878:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for f66023a4-3150-4251-bff2-d0486b8c0959 creative instance id [Roll(0.5):0.869611]
[758:775:0923/080939.990917:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 11 eligible ads after pacing
[758:775:0923/080939.990956:VERBOSE2:eligible_ads_priority_filter.cc(81)] 11 eligible ads with a priority of 1
[758:775:0923/080939.990989:VERBOSE1:ads_impl.cc(863)] Found 11 eligible ads
[758:775:0923/080939.991149:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 603cf41f-5313-4d2c-8c9c-6e5d43514a56
  parentUuid: aefb013b-0ea3-4921-91f2-ef2ac0bf94da
  creativeInstanceId: 7c644da6-051a-473f-9bac-bff887540953
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: technology & computing
  title: Campaign 1 CreativeSet 2 Ad 12
  body: Campaign 1 CreativeSet 2 Ad 12
  targetUrl: https://travala.com/
[758:775:0923/080939.991690:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid 603cf41f-5313-4d2c-8c9c-6e5d43514a56 in 120 seconds
[758:775:0923/080939.991802:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 603cf41f-5313-4d2c-8c9c-6e5d43514a56 and 7c644da6-051a-473f-9bac-bff887540953 creative instance id
[758:775:0923/080939.991982:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 7c644da6-051a-473f-9bac-bff887540953
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: technology & computing
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

Verification passed on



Brave | 1.14.84 Chromium: 85.0.4183.121 (Official Build) (64-bit)
-- | --
Revision | a81aa729a8e1fd413943a339393c82e7b8055ddc-refs/branch-heads/4183@{#1864}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified test plan from https://github.com/brave/internal/issues/720

Ads pacing - PTR = 0
Verified ads are not shown

[18184:8700:0923/174121.399:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 2 eligible ads before pacing
[18184:8700:0923/174121.406:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d175cdfd-57bf-46c3-9b00-89eed71c6ae5 creative instance id [Roll(0):0.970468]
[18184:8700:0923/174121.413:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for db2d16ff-d62e-4c1b-9e52-91f2ba727dd6 creative instance id [Roll(0):0.994477]
[18184:8700:0923/174121.416:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 0 eligible ads after pacing

Ads pacing - PTR=0 to PTR=1 through catalog update
Verified ad was shown

[8528:9468:0923/174915.908:VERBOSE1:ads_impl.cc(818)] Serving ad notification from untargeted category
[8528:9468:0923/174915.911:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 2 eligible ads before pacing
[8528:9468:0923/174915.917:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 2 eligible ads after pacing
[8528:9468:0923/174915.918:VERBOSE2:eligible_ads_priority_filter.cc(81)] 2 eligible ads with a priority of 1
[8528:9468:0923/174915.919:VERBOSE1:ads_impl.cc(863)] Found 2 eligible ads
[8528:9468:0923/174915.930:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: a659a476-f6a0-4568-a567-fd6c3642cfdd
  parentUuid: eca75695-11a1-484c-999b-de43566c0a86
  creativeInstanceId: d175cdfd-57bf-46c3-9b00-89eed71c6ae5
  creativeSetId: 175bc3ca-50f0-4749-bfc8-c7ff7482de0f
  category: untargeted
  title: Campaign 1 CreativeSet 1 Ad 1
  body: Campaign 1 CreativeSet 1 Ad 1
  targetUrl: https://travala.com/
[8528:9468:0923/174915.933:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid a659a476-f6a0-4568-a567-fd6c3642cfdd and d175cdfd-57bf-46c3-9b00-89eed71c6ae5 creative instance id
[8528:9468:0923/174915.934:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: d175cdfd-57bf-46c3-9b00-89eed71c6ae5
  creativeSetId: 175bc3ca-50f0-4749-bfc8-c7ff7482de0f
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

Ads pacing - PTR = 0.5 - untargated
50 eligible ads before pacing
21 eligible ads after pacing
21/50 = 0.42 (42%)

[6016:7380:0923/180758.904:VERBOSE1:ads_impl.cc(818)] Serving ad notification from untargeted category
[6016:7380:0923/180758.930:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 50 eligible ads before pacing
[6016:7380:0923/180758.930:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for f7e844a4-ac39-45b7-ba9b-2ace02a92bc6 creative instance id [Roll(0.5):0.700877]
[6016:7380:0923/180758.931:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for b875ff4f-aa3f-4773-a79f-e8f0cd08bdc8 creative instance id [Roll(0.5):0.880078]
[6016:7380:0923/180758.941:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 307a7ac4-29f1-483e-9257-ce033e3b5e51 creative instance id [Roll(0.5):0.645567]
[6016:7380:0923/180758.943:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for ad328ff9-bac9-4772-af06-a7fdd122107f creative instance id [Roll(0.5):0.97152]
[6016:7380:0923/180758.943:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for ba04e18e-644d-417e-bcfb-61a4e1bebdbb creative instance id [Roll(0.5):0.989832]
[6016:7380:0923/180758.951:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 9340f13f-0e3c-4f3f-b071-7140f35eb70e creative instance id [Roll(0.5):0.991146]
[6016:7380:0923/180758.953:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for e70ecd0d-441c-4a34-9042-b91e8e168b4e creative instance id [Roll(0.5):0.544767]
[6016:7380:0923/180758.954:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 221d036d-a815-42d2-944a-d8e894804b4f creative instance id [Roll(0.5):0.770249]
[6016:7380:0923/180758.961:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 8902146f-7699-4a4d-b935-d5b1d7f94e76 creative instance id [Roll(0.5):0.985191]
[6016:7380:0923/180758.961:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for cd8a81fc-5efb-41f1-99b6-945082c3e83a creative instance id [Roll(0.5):0.756783]
[6016:7380:0923/180758.963:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 196d452e-a1a5-40a6-9d72-9dff6dfe4267 creative instance id [Roll(0.5):0.795207]
[6016:7380:0923/180758.964:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d608b01c-2db7-4073-b946-9a15d70450d7 creative instance id [Roll(0.5):0.796495]
[6016:7380:0923/180758.965:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for a0d15395-1fc0-4616-83ff-8d3b9e1e7a5a creative instance id [Roll(0.5):0.748375]
[6016:7380:0923/180758.972:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 20f4a3ed-2187-43d0-b13c-c06422fccf2b creative instance id [Roll(0.5):0.83344]
[6016:7380:0923/180758.973:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for bfe0149e-7aa8-4a55-86bc-294e4913f24a creative instance id [Roll(0.5):0.828444]
[6016:7380:0923/180758.976:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for dcc69e3e-3ba7-43a2-9067-97dbd29c9f61 creative instance id [Roll(0.5):0.566103]
[6016:7380:0923/180758.976:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for f66023a4-3150-4251-bff2-d0486b8c0959 creative instance id [Roll(0.5):0.848639]
[6016:7380:0923/180758.983:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 76eb5134-4334-448a-ab04-4b64ec88f138 creative instance id [Roll(0.5):0.984012]
[6016:7380:0923/180758.983:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 93095831-599c-4ae9-81cb-a448dd5fba00 creative instance id [Roll(0.5):0.898968]
[6016:7380:0923/180758.985:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d1f3ce9e-95a7-4dd5-880e-ba97954edbb6 creative instance id [Roll(0.5):0.500405]
[6016:7380:0923/180758.994:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 269767c1-c6e8-4307-b1d2-25d35445c976 creative instance id [Roll(0.5):0.813692]
[6016:7380:0923/180758.994:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 70846bb8-9969-49b3-b5e7-e98337762f6b creative instance id [Roll(0.5):0.615576]
[6016:7380:0923/180758.995:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for a6122ca5-3d21-4d32-9e88-d6eb457f07e7 creative instance id [Roll(0.5):0.90019]
[6016:7380:0923/180758.997:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for bbb2d221-701d-41de-9368-2ec86c8c75aa creative instance id [Roll(0.5):0.966439]
[6016:7380:0923/180758.997:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 66326b14-e4f4-4597-a358-ae6134eb26c1 creative instance id [Roll(0.5):0.659491]
[6016:7380:0923/180759.005:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for d4704d65-878e-49f7-936c-9b86fd6df90c creative instance id [Roll(0.5):0.720064]
[6016:7380:0923/180759.006:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 24 eligible ads after pacing
[6016:7380:0923/180759.014:VERBOSE2:eligible_ads_priority_filter.cc(81)] 24 eligible ads with a priority of 1
[6016:7380:0923/180759.015:VERBOSE1:ads_impl.cc(863)] Found 24 eligible ads
[6016:7380:0923/180759.017:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 8a29173c-5632-4b95-b6c9-e25530fd18e1
  parentUuid: acde613d-8722-4a5d-b1b2-8d0a343f41db
  creativeInstanceId: 8584e37d-7549-4e61-a943-4cd83d26b97a
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: untargeted
  title: Campaign 1 CreativeSet 2 Ad 19
  body: Campaign 1 CreativeSet 2 Ad 19
  targetUrl: https://travala.com/
[6016:7380:0923/180759.018:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 8a29173c-5632-4b95-b6c9-e25530fd18e1 and 8584e37d-7549-4e61-a943-4cd83d26b97a creative instance id
[6016:7380:0923/180759.029:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 8584e37d-7549-4e61-a943-4cd83d26b97a
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: untargeted
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

Ads pacing - PTR = 0.5 - Technology & Computing
20 eligible ads before pacing
9 eligible ads after pacing
9/20 = 0.45 (45%)

[11828:17852:0923/181451.552:VERBOSE1:ads_impl.cc(334)] Browser state changed to idle
[11828:17852:0923/181511.569:VERBOSE1:ads_impl.cc(343)] Browser state changed to unidle
[11828:17852:0923/181511.578:VERBOSE1:ads_impl.cc(726)] No purchase intent winning categories
[11828:17852:0923/181511.578:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[11828:17852:0923/181511.579:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[11828:17852:0923/181511.588:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[11828:17852:0923/181511.591:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[11828:17852:0923/181511.600:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[11828:17852:0923/181511.601:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[11828:17852:0923/181511.601:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[11828:17852:0923/181511.609:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[11828:17852:0923/181511.611:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[11828:17852:0923/181511.612:VERBOSE1:ads_impl.cc(788)]   technology & computing
[11828:17852:0923/181511.619:VERBOSE1:ads_impl.cc(788)]   personal finance
[11828:17852:0923/181511.620:VERBOSE1:ads_impl.cc(788)]   food & drink
[11828:17852:0923/181511.632:VERBOSE2:eligible_ads_pacing_filter.cc(25)] 20 eligible ads before pacing
[11828:17852:0923/181511.632:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for cd8a81fc-5efb-41f1-99b6-945082c3e83a creative instance id [Roll(0.5):0.744973]
[11828:17852:0923/181511.638:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for a0d15395-1fc0-4616-83ff-8d3b9e1e7a5a creative instance id [Roll(0.5):0.760114]
[11828:17852:0923/181511.639:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 20f4a3ed-2187-43d0-b13c-c06422fccf2b creative instance id [Roll(0.5):0.696891]
[11828:17852:0923/181511.642:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 3833014b-0ea2-428f-ad89-343e51b36284 creative instance id [Roll(0.5):0.798311]
[11828:17852:0923/181511.643:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 476dbf31-4372-41cd-a7b1-c5f89a894352 creative instance id [Roll(0.5):0.94926]
[11828:17852:0923/181511.644:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 8584e37d-7549-4e61-a943-4cd83d26b97a creative instance id [Roll(0.5):0.914336]
[11828:17852:0923/181511.652:VERBOSE2:eligible_ads_pacing_filter.cc(32)]   Pacing ad delivery for 56ce24f3-027c-473b-80bb-fdbed42bd57d creative instance id [Roll(0.5):0.530223]
[11828:17852:0923/181511.653:VERBOSE2:eligible_ads_pacing_filter.cc(40)] 13 eligible ads after pacing
[11828:17852:0923/181511.660:VERBOSE2:eligible_ads_priority_filter.cc(81)] 13 eligible ads with a priority of 1
[11828:17852:0923/181511.662:VERBOSE1:ads_impl.cc(863)] Found 13 eligible ads
[11828:17852:0923/181511.663:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 12388dc1-d0f3-4f57-a585-127d0fff9e85
  parentUuid: f77b9004-edb2-4cd6-8047-2e3a72691f1b
  creativeInstanceId: 5327c24b-663d-41b9-9138-8460ad3a5a5f
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: technology & computing
  title: Campaign 1 CreativeSet 2 Ad 14
  body: Campaign 1 CreativeSet 2 Ad 14
  targetUrl: https://travala.com/
[11828:17852:0923/181511.673:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 12388dc1-d0f3-4f57-a585-127d0fff9e85 and 5327c24b-663d-41b9-9138-8460ad3a5a5f creative instance id
[11828:17852:0923/181511.682:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 5327c24b-663d-41b9-9138-8460ad3a5a5f
  creativeSetId: 37f7ba07-355d-4d0f-8cdb-b9241550c0c8
  category: technology & computing
  targetUrl: https://travala.com/
  geoTarget: US
  confirmationType: view

@kjozwiak kjozwiak mentioned this issue Sep 23, 2020
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.14.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fixes follow up to #11057: Implement client ads pacing mechanism brave/brave-core
5 participants
@tmancey @kjozwiak @LaurenWags @btlechowski @GeetaSarvadnya