Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] https://[%2A.]firebase app.com in allowed cookies #11679

Closed
srirambv opened this issue Sep 11, 2020 · 4 comments
Closed

[Android] https://[%2A.]firebase app.com in allowed cookies #11679

srirambv opened this issue Sep 11, 2020 · 4 comments
Labels
bug closed/duplicate Issue has already been reported needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality privacy QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Report from community https://community.brave.com/t/found-https-2a-firebase-app-com-in-allowed-cookies/154373

Steps to reproduce

  1. Go to settings
  2. Click on site settings
  3. Click on all sites or cookies
  4. https://[%2A.]firebase app.com is in both all sites and allowed cookies and cannot be deleted.

Actual result

https://[%2A.]firebase app.com is in both all sites and allowed cookies and cannot be deleted.

Expected result

Not set any cookies by default

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.12.113

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv srirambv added bug needs-investigation A bug not 100% confirmed/fixed QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Sep 11, 2020
@urbenlegend
Copy link

This is not just on Android. I see this on Desktop as well.

@urbenlegend
Copy link

Found out what's causing it on Desktop at least. If you enable Allow Google login buttons on third party sites, these cookie rules will show up in the Allow section. If you turn it off, those rules disappear.

However, I can not find the equivalent option on mobile.

@pes10k
Copy link
Contributor

pes10k commented Sep 15, 2020

This is not a bug, its intentionally tied to google auth, since firebase depends on google for auth (in other words, you can only auth with a firebase app in most cases with a google login button) This was discussed in: brave/brave-core#5952 . We can reopen of course if needed, but wanted to at least provide that as background.

There is already an issue for adding UI to control this (and other privacy settings) in android too #9536. If this is getting more user attention / notes, maybe that should be prioritized higher?

Also, fwiw, these kinds of intentional-but-maybe-unexpected-connections should be much less needed once #8514 lands.

TL;DR; i think this issue is a duplicate and can be closed, mostly because the actionable parts are either existing-intentional choices, or covered by other issues.

@pes10k pes10k added the closed/duplicate Issue has already been reported label Sep 15, 2020
@pes10k
Copy link
Contributor

pes10k commented Sep 15, 2020

I'm going to close this issue for the reasons described above, but thanks much to @srirambv for reporting and for @urbenlegend for adding the details. I'll also note in #9536 that the feature is being requested / useful for community raised issues too. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/duplicate Issue has already been reported needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality privacy QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants