Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in ZIP build: Remove firebaseapp and accounts.google from websites that can always use cookies by default #25647

Closed
rany2 opened this issue Sep 27, 2022 · 2 comments

Comments

@rany2
Copy link

rany2 commented Sep 27, 2022

Description

Brave's zip build (i.e. https://github.com/brave/brave-browser/releases/download/v1.46.15/brave-browser-nightly-1.46.15-linux-amd64.zip) has firebaseapp and accounts.google.com from websites that can always use cookies by default. This doesn't happen in the .deb build of Brave.

image

Brave version (brave://version info)

Brave 1.43.93 Chromium: 105.0.5195.127 (Official Build) unknown (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Linux
JavaScript V8 10.5.218.8
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36
Command Line /app/brave/brave --disable-features=WebAssemblyTrapHandler,DesktopPWAsRunOnOsLogin --enable-crashpad --disable-domain-reliability --enable-dom-distiller --component-updater=url-source=https://go-updater.brave.com/extensions --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --disable-features=DesktopPWAsRunOnOsLogin,WebAssemblyTrapHandler --flag-switches-begin --flag-switches-end
Executable Path /app/brave/brave
Profile Path /home/user/.var/app/com.brave.Browser/config/BraveSoftware/Brave-Browser/Default

Miscellaneous Information:

Original issue reported in flathub/com.brave.Browser#193

@mherrmann
Copy link

mherrmann commented Oct 3, 2022

I believe this is actually not related to ZIP/DEB but to the setting "Allow Google log in buttons on third party sites". Please see #11679 (comment).

@rany2
Copy link
Author

rany2 commented Oct 6, 2022

Yes, and it appears that .deb actually has the same defaults. I took the original reporter for their word but apparently this isn't the case. Closing

@rany2 rany2 closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants