-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all non-locale string instances of innerHTML #11686
Comments
and add npm script to check for Trusted Type violations. locale strings will be fixed in a separate PR. fix brave/brave-browser#11686
and add npm script to check for Trusted Type violations. locale strings will be fixed in a separate PR. fix brave/brave-browser#11686
and add npm script to check for Trusted Type violations. locale strings will be fixed in a separate PR. fix brave/brave-browser#11686
Marking as |
Verification completed using:
Verified test plan from description.
Verification passed on
Verified test plan from the description.
Verification passed on
Verified test plan from description.
|
Removed |
Removing |
We will need this in order to be able to enabled trusted types by default. (See #11642, which covers the usages in locale strings.)
Regression tests for QA
brave://settings
, make sure that all settings pages load correctly without any UI regressions. Change at least one setting and verify that the setting is actually changed.brave://settings/help
and make sure that clicking on the version opens a new tab to brave.com/latest.brave://settings/importData
loads correctly and that you're able to import the specified types of data from at least one other browser. Make sure that unchecking a dialog item doesn't import that type of data.brave://flags
shows a link to download the beta or nightly versions of Brave.Add to Brave
instead ofAdd to Chrome
.The text was updated successfully, but these errors were encountered: