Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapp detection should now use window.ethereum and not window.web3 #11698

Closed
bbondy opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6648
Closed

Dapp detection should now use window.ethereum and not window.web3 #11698

bbondy opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6648

Comments

@bbondy
Copy link
Member

bbondy commented Sep 14, 2020

Description

On November 16, 2020 MetaMask plans to remove window.web3 MetaMask/metamask-extension#8077 in favor of window.ethereum

We should remove our Dapp detection for window.web3 and use window.ethereum instead.

QA test plan

  1. Fresh profile
  2. Go to cryptokitties.co
  3. Ensure the dapp detection prompt still comes up
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Desktop labels Sep 14, 2020
@bbondy bbondy self-assigned this Sep 14, 2020
@srirambv srirambv changed the title Remove Dapp detection for window.web3 and replace to window.ethereum [Desktop] Remove Dapp detection for window.web3 and replace to window.ethereum Sep 14, 2020
@bbondy bbondy changed the title [Desktop] Remove Dapp detection for window.web3 and replace to window.ethereum Remove Dapp detection for window.web3 and replace to window.ethereum Sep 14, 2020
@bbondy bbondy changed the title Remove Dapp detection for window.web3 and replace to window.ethereum Dapp detection should now use window.ethereum and not window.web3 Sep 15, 2020
@bbondy bbondy added this to the 1.16.x - Nightly milestone Sep 18, 2020
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Oct 7, 2020
@btlechowski
Copy link

Verification passed on

Brave 1.16.55 Chromium: 86.0.4240.72 (Official Build) dev (64-bit)
Revision 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified the info bar is shown. Verified that the injected script uses window.ethereum
image

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified dapp detection script uses window.ethereum instead of window.web3
    image

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Windows 10 OS Version 1809 (Build 17763.1490)
  • Verified dapp detection script uses window.ethereum instead of window.web3
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants