Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window ethereum dapp detection and minification #6648

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 15, 2020

Fix brave/brave-browser#11725
Fix brave/brave-browser#11698

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy requested a review from ryanml September 15, 2020 20:21
@bbondy bbondy self-assigned this Sep 15, 2020
@bbondy bbondy force-pushed the window-ethereum-dapp-detection branch from 7d0c8c4 to b25908c Compare September 15, 2020 22:19
@bbondy bbondy merged commit 9f1496e into master Sep 16, 2020
@bbondy bbondy deleted the window-ethereum-dapp-detection branch September 16, 2020 18:07
@bbondy bbondy added this to the 1.16.x - Nightly milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapp detection script should be minified Dapp detection should now use window.ethereum and not window.web3
2 participants