-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Estimated earnings and Ad notifications are not updating for users #11952
Comments
Verification passed using
Confirm unblinded tokens are refilled if we have less than 10 unblinded tokens when triggering an event to serve an ad notification
Confirm failed confirmations are retried after attempting to download the catalogViewed an ad, enabled Charles re-write rule to make confirmation fail, then dismissed the ad to create a failed confirmation:
Closed browser, disabled rewrite rule, relaunched browser. Confirmed after catalog was downloaded, the failed confirmations for retry were scheduled:
Confirmed at expected time (0 hours, 10 minutes, 42 seconds at 3:46 PM) from logs, the failed confirmation was retried successfully:
Confirm ad rewards are reconciled upon browser launch
Confirm ad rewards are reconciled after restoring a wallet
Confirm ad rewards are reconciled after redeeming unblinded payment tokens
Confirm ad rewards are reconciled after claiming an ad promotion
Verification passed on
Verified catalog is downloaded upon browser launch
Verified Confirm catalog is downloaded every ~2 hoursVerified catalog is scheduled to be downloaded
Verified on staging that catalog is downloaded at the appointed hour:
Verified catalog download is not started if currently retrying a previously failed download
Verified Confirm unblinded payment tokens are redeemed ~24 hours
Verified unblinded payment tokens redemption is not started if currently retrying a previously failed downloadVerified
Confirm failed confirmations are retried when an unblinded token redemption failsViewed an ad, enabled Charles re-write rule to make confirmation fail, then dismissed the ad to create a failed confirmation:
Disabled Charles rewrite rule and waited until the time mentioned in the logs, confirmed previously failed confirmation was retried and successful:
Confirm unblinded tokens are refilled to 50 if we are below the threshold after attempting to download the catalogEnable Rewards, wait until everything is complete (catalog download, tokens fetched, etc). View an ad, dismiss ad. Enable Charles rewrite rule outlined in https://github.com/brave/internal/issues/731. Use +1/-1 on Ad history to use tokens so that you have less than 20 left:
Close browser. Disable Charles rewrite rule. Relaunch browser. Confirm after catalog is downloaded that tokens are refilled successfully:
Confirm unblinded tokens are refilled to 50 if we are below the threshold after redeeming an unblinded tokenEnable Rewards, wait until everything is complete (catalog download, tokens fetched, etc). View an ad, dismiss ad. Use +1/-1 on Ad history to use tokens just until you have 20 left:
Use the other (+1 or -1) button to get to 19 and confirm that tokens are refilled successfully:
Verification in progress with
Verified catalog is downloaded upon browser launch
Verified Confirm catalog is downloaded every ~2 hoursCatalog download is scheduled:
Used
Verified catalog download is not started if currently retrying a previously failed download
Verified unblinded payment tokens are redeemed ~24 hours
Used
Verified unblinded payment tokens redemption is not started if currently retrying a previously failed downloadVerified
Verified unblinded tokens are refilled if we have less than 10 unblinded tokens when triggering an event to server an ad notificationVerified that ad is not shown when there are not enough unblinded tokens:
Verified tokens were refilled once rewrite was turned off:
Verified that after unblinded tokens are refilled, ads are shown Verified failed confirmations are retried after attempting to download the catalogViewed an ad, enabled Charles re-write rule to make confirmation fail, then dismissed the ad to create a failed confirmation:
Closed browser, disabled rewrite rule, relaunched browser. Confirmed after catalog was downloaded, the failed confirmations for retry were scheduled:
Confirmed at expected time (
Verified failed confirmations are retried when an unblinded token redemption failsViewed an ad, enabled Charles re-write rule to make confirmation fail, then dismissed the ad to create a failed confirmation:
Disabled Charles rewrite rule and waited until the time mentioned in the logs (
Verified unblinded tokens are refilled to 50 if we are below the threshold after attempting to download the catalogEnable Rewards, wait until everything is complete (catalog download, tokens fetched, etc). View an ad, dismiss ad. Enable Charles rewrite rule outlined in brave/internal#731. Use +1/-1 on Ad history to use tokens so that you have less than 20 left:
Close browser. Disable Charles rewrite rule. Relaunch browser. Confirm after catalog is downloaded that tokens are refilled successfully:
Verified unblinded tokens are refilled to 50 if we are below the threshold after redeeming an unblinded tokenEnable Rewards, wait until everything is complete (catalog download, tokens fetched, etc). View an ad, dismiss ad. Use +1/-1 on Ad history to use tokens just until you have 20 left:
Use the other (+1 or -1) button to get to 19 and confirm that tokens are refilled successfully:
Verified ad rewards are reconciled upon browser launchLaunch brave with clean profile staging env
Verified ad rewards are reconciled after redeeming unblinded payment tokensLaunch brave with clean profile staging env (used
Blocked:
above two result in:
Verification PASSED on
Confirm ad rewards are reconciled after restoring a wallet* launch brave with clean profile using using the following:
Confirm ad rewards are reconciled after claiming an ad promotion* launch brave with clean profile using using the following:
|
Verification passed on Samsung Galaxy J3 version 5.1.1 running
Verification passed on Brave v1.15.74 on Samsung Galaxy Tab S5e (Android 9.0)
|
Description
Estimated earnings and Ad notifications are not updating for users
Steps to Reproduce
Actual result:
Tokens are refilled twice, see "Refill unblinded tokens" in the rewards log
Expected result:
Tokens should only be refilled once
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: