Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new 'Simple View' for Shields #1196

Closed
rebron opened this issue Sep 19, 2018 · 8 comments · Fixed by brave/brave-core#2874
Closed

Add new 'Simple View' for Shields #1196

rebron opened this issue Sep 19, 2018 · 8 comments · Fixed by brave/brave-core#2874
Assignees
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 19, 2018

Test plan

See brave/brave-core#2874

Description

Show a "Simple view" on Shields which will be the global default view for all users. The colors and fonts should be the same as what already exists in the Shields panel.

Design

shields simple 1

shields simple and advanced off

shields simple 2

User Flows

user flows - simple and advanced per site customizatiom

Abtract link for more CSS and plain text: https://share.goabstract.com/346f8cac-0c8f-4ebf-b76f-716a92e6c05b

@rebron rebron added this to the 1.0 milestone Sep 19, 2018
@rebron rebron added feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team labels Sep 19, 2018
@rebron rebron changed the title update shields panel with new UI Rework shields panel into simple view Sep 28, 2018
@rebron rebron modified the milestones: 1.0, 0.56.x - Beta Oct 16, 2018
@rebron rebron modified the milestones: 0.56.x - Beta, 0.57.x - Dev Oct 26, 2018
@rebron rebron removed this from the 0.57.x - Dev milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@tildelowengrimm tildelowengrimm added priority/P5 Not scheduled. Don't anticipate work on this any time soon. feature/shields/panel Front-end design and functionality of the Shields panel. labels Oct 31, 2018
@tildelowengrimm tildelowengrimm added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Nov 6, 2018
@tildelowengrimm
Copy link
Contributor

Karen is going to come through with some slightly-updated designs which mach the typeface weights and colors from #1956.

@srirambv
Copy link
Contributor

srirambv commented Aug 29, 2019

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux
  • Verified test plan from Add support for multiple views on Shields brave-core#2874
  • Verified one time message is shown
    image
  • Verified advance view is retained between pages after dismissing the notification
  • Verified simple view is retained between pages if advance view is never clicked or changed in settings

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that Simple View was being used as default view with new profiles
  • ensured that the warning message appears when switching to Advanced View via the shields panel or brave://settings
  • ensured that Simple View or Advanced View globally for every tab opened
  • ensured that the settings persisted after several browser restarts
  • ensured that you can disable/enable shields without any issues (changing the views via brave://settings during disabled states)
  • Upgraded 0.68.142 CR: 77.0.3865.90 --> 0.69.130 Chromium: 77.0.3865.90 and ensured the above cases worked without issues
  • Reproduced existing users getting warning message when opening shields for the first time - follow up to 5582 #5924 which was labelled as Wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants