Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify wallet login message isn't translated in brave://rewards settings page for few locales #12017

Closed
GeetaSarvadnya opened this issue Oct 6, 2020 · 2 comments

Comments

@GeetaSarvadnya
Copy link

Description

Verify wallet login message isn't translated in brave://rewards settings page for few locales

Steps to Reproduce

  1. Set OS locale to Kannada
  2. Install brave 1.15.x
  3. Enable rewards
  4. Click on Verify wallet in brave://rewards settings page

Actual result:

Verify wallet login message isn't translated in brave://rewards settings page for few locales
image

Expected result:

Verify wallet login message should be translated to OS locale

1.14.x
image

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.15.71 Chromium: 86.0.4240.72 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) (64-ಬಿಟ್)
ಪರಿಷ್ಕರಣೆ 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS Windows 10 OS Version 1809 (Build 17763.1397)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Not sure
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron

mkarolin added a commit to brave/brave-core that referenced this issue Oct 6, 2020
Brings back all strings that were removed as a result of uplifting the
latest l10n changes from transifex.

Fixes brave/brave-browser#12012
Fixes brave/brave-browser#12013
Fixes brave/brave-browser#12017
@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2020

Closing and moved into https://github.com/brave/brave-browser/milestone/135 as brave/brave-core#6788 has been merged into 1.15.x 👍

@kjozwiak kjozwiak closed this as completed Oct 7, 2020
@kjozwiak kjozwiak added this to the 1.15.x - Release #1 milestone Oct 7, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Oct 7, 2020

Verified passed with

Brave | 1.15.72 Chromium: 86.0.4240.75 (Offizieller Build) (x86_64)
-- | --
Überarbeitung | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
Betriebssystem | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description for both French and German:

French
12017 French

German
12017 German


Verification passed on

Brave 1.15.72 Chromium: 86.0.4240.75 (Official Build) (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Ubuntu 18.04 LTS

Verified STR from description

image
image


Verification passed on

क्रोमियम 1.15.72 Chromium: 86.0.4240.75 (आधिकारिक बिल्ड) (64-बिट)
पुनरीक्षण c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Windows 8.1 (Build 9600.19817)

Verified STR from description
Hindi
image

Brave	1.15.72 Chromium: 86.0.4240.75 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) (64-ಬಿಟ್)
ಪರಿಷ್ಕರಣೆ	c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS	Windows 10 OS Version 1809 (Build 17763.1397)

Kannada
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants