Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of custom background images in tip dialog #12057

Closed
zenparsing opened this issue Oct 8, 2020 · 2 comments · Fixed by brave/brave-core#6930
Closed

Improve display of custom background images in tip dialog #12057

zenparsing opened this issue Oct 8, 2020 · 2 comments · Fixed by brave/brave-core#6930

Comments

@zenparsing
Copy link

zenparsing commented Oct 8, 2020

Description

The new rewards tipping dialog uses a different aspect ratio for custom banner images, and when existing banner images are displayed within the new tip dialog, they are cropped and scaled to cover the available space. We should try to scale images with wide aspect ratios more gracefully.

Also, when custom backgrounds have a light color it can become difficult to read the white banner text.

@zenparsing zenparsing self-assigned this Oct 8, 2020
@zenparsing zenparsing changed the title Gracefully display wide aspect ratio tipping banner images [Desktop] Gracefully display wide aspect ratio tipping banner images Oct 8, 2020
@zenparsing zenparsing changed the title [Desktop] Gracefully display wide aspect ratio tipping banner images [Desktop] Improve display of custom background images in new tip dialog Oct 22, 2020
@zenparsing zenparsing changed the title [Desktop] Improve display of custom background images in new tip dialog [Desktop] Improve display of custom background images in tip dialog Oct 22, 2020
@zenparsing
Copy link
Author

After speaking with @codybanxs it was decided to leave the scaling as-is for now and add a missing linear gradient background to custom banner images to improve readability.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 20, 2020

Verified passed with

Brave | 1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 10.14.6 (Build 18G6042)

Verified test plan from brave/brave-core#6930

1.17.73:
1 17 x

1.18.59:
1 18 x


Verification passed on


Brave | 1.18.59 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)


Verified test plan from brave/brave-core#6930
1.17.x
image

1.18.59:
image


Verification passed on

Brave 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6930
1.17.x
image

1.18.x
image

@rebron rebron changed the title [Desktop] Improve display of custom background images in tip dialog Improve display of custom background images in tip dialog Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment