-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Implement design for tipping banner #11393
Comments
Verification completed with
Verified banner colors from linked Figma doc above Verified test plan from brave/brave-core#6626 Case 1: One-time tipping - Unverified publisherConfirmed banner matches designs for one time tipping without credit card option. Case 1: One-time tipping - verified, not KYC'd publisherConfirmed banner matches designs for one time tipping without credit card option. Case 1: One-time tipping - KYC'd publisherConfirmed banner matches designs for one time tipping without credit card option. Confirmed if KYC'd publisher does not have custom banner, the correct background, title, description, favicon, and amounts display (defaults): Case 2: Setting a monthly contribution - unverified publisherConfirmed Monthly is selected by default when choosing this option from the panel. Case 2: Setting a monthly contribution - verified, not KYC'd publisherConfirmed Monthly is selected by default when choosing this option from the panel. Case 2: Setting a monthly contribution - KYC'd publisherConfirmed Monthly is selected by default when choosing this option from the panel. Case 3: One-time tipping with existing monthly contribution - unverified publisherConfirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured. Confirmed selecting the "Monthly" shows cancel/change UI. Confirmed "Cancel" flow:
Confirmed "Change amount" flow:
Confirmed monthly contribution can still be removed from panel and brave://rewards.
Case 3: One-time tipping with existing monthly contribution - verified, not KYC'd publisherConfirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured. Confirmed selecting the "Monthly" shows cancel/change UI. Confirmed "Cancel" flow:
Confirmed "Change amount" flow:
Confirmed monthly contribution can still be removed from panel and brave://rewards. Case 3: One-time tipping with existing monthly contribution - KYC'd publisherConfirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured. Confirmed selecting the "Monthly" shows cancel/change UI. Confirmed "Cancel" flow:
Confirmed "Change amount" flow:
Confirmed monthly contribution can still be removed from panel and brave://rewards. Case 4: In-line tipping - unverified publisher (Twitter, Reddit, GitHub)Confirmed banner is shown when clicking on in-line tip button. Confirmed one time tip is sent to Pending list for unverified publishers. Case 4: In-line tipping - verified, non-KYC'd publisher (Reddit)Unable to check Twitter/GH as there is no verified, non-KYC'd publisher set up on staging env for these types. Confirmed banner is shown when clicking on in-line tip button. Confirmed one time tip is sent to Pending list for verified, not KYC'd publishers. Case 4: In-line tipping - KYC'd publisher (Reddit)Confirmed banner is shown when clicking on in-line tip button. Confirmed one time tip is sent as expected. Verification passed on
Verified banner colors from linked Figma doc above Verified test plan from brave/brave-core#6626 Case 1: One-time tipping - Unverified publisherConfirmed banner matches designs for one time tipping without credit card option. Case 1: One-time tipping - verified, not KYC'd publisherConfirmed banner matches designs for one time tipping without credit card option. Case 1: One-time tipping - KYC'd publisherConfirmed banner matches designs for one time tipping without credit card option. Confirmed if KYC'd publisher does not have custom banner, the correct background, title, description, favicon, and amounts display (defaults): Case 2. Setting a monthly contribution - unverified publisherConfirmed Monthly is selected by default when choosing this option from the panel. Case 2: Setting a monthly contribution - verified, not KYC'd publisherConfirmed Monthly is selected by default when choosing this option from the panel. Case 2: Setting a monthly contribution - KYC'd publisherConfirmed Monthly is selected by default when choosing this option from the panel. Case 3: One-time tipping with existing monthly contribution - unverified publisherConfirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured. Confirmed selecting the "Monthly" shows cancel/change UI. Confirmed "Cancel" flow: Selecting "Cancel" matches designs from figma. Confirmed "Change amount" flow:
Confirmed monthly contribution can still be removed from panel and brave://rewards. Case 3: One-time tipping with existing monthly contribution - verified, not KYC'd publisherConfirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured. Confirmed selecting the "Monthly" shows cancel/change UI. Confirmed "Cancel" flow: Selecting "Cancel" matches designs from figma. Confirmed "Change amount" flow:
Confirmed monthly contribution can still be removed from panel and brave://rewards. Case 3: One-time tipping with existing monthly contribution - KYC'd publisherConfirmed expected asterisk/messaging on tip banner when selecting "Send a tip" after a monthly contribution is already configured. Confirmed selecting the "Monthly" shows cancel/change UI. Confirmed "Cancel" flow: Selecting "Cancel" matches designs from figma. Confirmed monthly contribution can still be removed from panel and brave://rewards. Case 4: In-line tipping - unverified publisher (Twitter, Reddit, GitHub)Confirmed banner is shown when clicking on in-line tip button. Confirmed one time tip is sent to Pending list for unverified publishers. Case 4: In-line tipping - verified, non-KYC'd publisher (Reddit)Unable to check Twitter/GH as there is no verified, non-KYC'd publisher set up on staging env for these types. Confirmed banner is shown when clicking on in-line tip button. Confirmed one time tip is sent to Pending list for verified, not KYC'd publishers. Case 4: In-line tipping - KYC'd publisher (Reddit)Confirmed banner is shown when clicking on in-line tip button. |
You can find designs in https://www.figma.com/file/EDGI52tfWG1ggC9ZYFguXy/tipping-banner-revamp-copy.
The text was updated successfully, but these errors were encountered: