Update Startpage search to give attribution to Brave

[bsclifton]

Test plan

New profile

1. Visit brave://settings/searchEngines and set Start Page as default engine
2. Do a search for cats in the omnibox
3. Verify search URL is in the format like https://www.startpage.com/do/search?q=cats&segment=startpage.brave

Existing profile

1. Use an older version of Brave
2. Set StartPage as default (notice casing)
3. Do a search for cats in the omnibox
4. Verify search URL has pl=opensearch in it
5. Upgrade to updated version
6. Visit brave://settings/searchEngines
7. Ensure engine is showing as Startpage and not StartPage
8. Do a search for cats in the omnibox
9. Verify search URL is in the format like https://www.startpage.com/do/search?q=cats&segment=startpage.brave

Description

We currently offer StartPage in our list of "Default search engines" (visible on brave://settings/searchEngines)

The integration here is just using the Open Search provided parameters. We should update so that Brave can be attributed for the search.

Also - the branding should be Startpage and not StartPage

Steps to Reproduce

1. New profile
2. Visit brave://settings/searchEngines and set Start Page as default engine
3. Do a search for cats in the omnibox

Actual result:

Search URL is in format like https://www.startpage.com/do/dsearch?query=cats&cat=web&pl=opensearch

Expected result:

Search URL should be in the format like https://www.startpage.com/do/search?q=cats&segment=startpage.brave

[GeetaSarvadnya]

Verification is in-progress

Brave | 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

• Verified the STR from the description

New profile

• Verified that default engine cab be set to Startpage in brave://settings/searchEngines
• Performed search cats in the omnibox and ensured search engine formate is displayed like https://www.startpage.com/do/search?q=cats&segment=startpage.brave
  
• Ensured default search engine is showing as Startpage in brave://settings/search
  

Existing profile

• Installed older version 1.12.x and set the default search engine as Startpage and performed search cats and ensures that pl=opensearch in the search bar
  

pl=opensearch

• Ensured default search engine is showing as StartPage in brave://settings/search
  

• Upgraded profile to 1.16.68 and ensured StartPage is displayed as Startpage in brave://settings/searchEngines
  

• Ensured default search engine is showing as Startpage in brave://settings/search
  

• Performed search cats in the omnibox and ensured search engine formate is displayed like https://www.startpage.com/do/search?q=cats&segment=startpage.brave
  

---

Verified passed with

Brave	1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

• Verified test plan from Update Startpage search to give attribution to Brave #12257 (comment) and items from Updated Startpage integration brave-core#6916 (comment)

• Confirmed expected behavior for new profile case

• Confirmed expected behavior for existing profile case

Confirmed casing on Startpage in multiple areas

brave://welcome page:

brave://settings/

Omnibox search:

Right click search:

Confirmed search URL is configured as expected

Confirmed search URL shows as expected

---

Verification passed on

Brave	1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	Ubuntu 18.04 LTS

• Verified test plan from Update Startpage search to give attribution to Brave #12257 (comment) and items from Updated Startpage integration brave-core#6916 (comment)

• Confirmed expected behavior for new profile case

• Confirmed expected behavior for existing profile case

Confirmed casing on Startpage in multiple areas

brave://welcome page:

brave://settings/

Omnibox search:

Right click search:

Confirmed search URL is configured as expected

Confirmed search URL shows as expected


---

Verification PASSED on Samsung S10+ running Android 10 using 1.16.68 CR: 86.0.4240.111.

• Verified the STR/Cases outlined via Update Startpage search to give attribution to Brave #12257 (comment)
• Verified that the correct behaviour/changes are being applied on new profiles
• Verified that the correct behaviour/changes are being applied on upgraded profiles
• ensured that the startpage.brave segment was being appended in the following cases:
  • using the omnibox while Startpage is the default search engine
  • right clicking on a word and selecting Web Search"
• ensured that searching via startpage.com didn't append the startpage.brave segment
• Createdhttps://github.com/Startpage missing from onboarding #12340 & StartPage string not updating to Startpage if already selected as default before upgrading #12342

Ensured that the correct casing was being used throughout Brave

**`Standard Tab Default Choices`**

Private Tab Default Choices

SP Selected as Default

Ensured that the correct URL segment/format is being used

---

Verification passed on Brave v1.16.68 on Samsung Galaxy Tab S5e (Android 9.0)

• Verified the STR/Cases outlined via Update Startpage search to give attribution to Brave #12257 (comment)
• Verified that the correct behaviour/changes are being applied on new profiles
• Verified that the correct behaviour/changes are being applied on upgraded profiles
• ensured that the startpage.brave segment was being appended in the following cases:
  • using the omnibox while Startpage is the default search engine
  • right clicking on a word and selecting Web Search"
• ensured that searching via startpage.com didn't append the startpage.brave segment
• Createdhttps://github.com/Startpage missing from onboarding #12340 & StartPage string not updating to Startpage if already selected as default before upgrading #12342

Ensured that the correct casing was being used throughout Brave

**`Standard Tab Choices`** 

Private Tab Default Choices

SP Selected as Default

Ensured that the correct URL segment/format is being used