Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test on Windows - BraveRewardsBrowserTest.ToggleAutoContribute #1284

Closed
NejcZdovc opened this issue Sep 26, 2018 · 3 comments · Fixed by brave/brave-core#1110
Closed

Fix failing test on Windows - BraveRewardsBrowserTest.ToggleAutoContribute #1284

NejcZdovc opened this issue Sep 26, 2018 · 3 comments · Fixed by brave/brave-core#1110
Assignees
@jasonrsadler
Labels
OS/Windows QA/No release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Follow up from brave/brave-core#465 (review)
@NejcZdovc NejcZdovc added this to the 1.0 milestone Sep 26, 2018
@jasonrsadler jasonrsadler changed the title Fix failing test on Windows Fix failing test on Windows - BraveRewardsBrowserTest.ToggleAutoContribute Oct 10, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc assigned yrliou and unassigned jasonrsadler Nov 2, 2018
@NejcZdovc
Copy link
Contributor Author

if i am not mistaken @yrliou fixed all tests. If I am mistaken, please reopen

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Nov 2, 2018
@yrliou
Copy link
Member

yrliou commented Nov 2, 2018

Clear my assignment because I wasn't looking into this test but some other known failing tests.

@yrliou yrliou removed their assignment Nov 2, 2018
@jasonrsadler
Copy link

Reopening this as it is failing consistenly on Windows

@jasonrsadler jasonrsadler reopened this Dec 16, 2018
@jasonrsadler jasonrsadler self-assigned this Dec 16, 2018
@jasonrsadler jasonrsadler removed this from the Dupe / Invalid / Not actionable milestone Dec 16, 2018
@jasonrsadler jasonrsadler mentioned this issue Dec 16, 2018
Merged
18 tasks
@NejcZdovc NejcZdovc added this to the 0.60.x - Dev milestone Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonrsadler jasonrsadler

Labels
OS/Windows QA/No release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixes broken browser test
5 participants
@bbondy @kjozwiak @yrliou @NejcZdovc @jasonrsadler