Enabling brave rewards for Windows #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Sep 18, 2018
|
@gdregalo created issue in brave browser for this PR |
This was referenced Sep 18, 2018
Merged
bridiver
reviewed
Sep 18, 2018
| @@ -125,7 +127,13 @@ bool PublisherInfoBackend::EnsureInitialized() { | |||
|
|
|||
| leveldb_env::Options options; | |||
| options.create_if_missing = true; | |||
| #if defined(OS_WIN) && (defined(UNICODE) || defined(_UNICODE)) | |||
There was a problem hiding this comment.
#if defined(OS_WIN)
std::string path = base::UTF16ToUTF8(path_.value());
#else
NejcZdovc
force-pushed
the
win_brave_rewards_enabled
branch
from
d08c021 to
3999e76
Compare
|
@gdregalo just a heads up, I just rebased this PR to the latest master. Will check out now if everything works on windows |
NejcZdovc
reviewed
Sep 20, 2018
There was a problem hiding this comment.
Run it on windows and it's working. Wallet was created and I could claim grant.
Run npm run test -- brave_unit_tests and it's passing.
Run npm run test -- brave_browser_tests and it's failing on one test
1 test crashed:
BraveRewardsBrowserTest.ToggleAutoContribute (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:228)
Blocked on security review
|
@jasonrsadler please check this failing test |
|
pulled 3999e766f1d451f48e7285da0b32faae815fff39 into #487 |
NejcZdovc
force-pushed
the
win_brave_rewards_enabled
branch
from
3999e76 to
5e4267b
Compare
bbondy
approved these changes
Sep 26, 2018
bbondy
added a commit
that referenced
this pull request
Sep 26, 2018
Enabling brave rewards for Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR to brave-core. I don't know how to handle all the items below. Please someone explain. Please review the code changes. It enables and compiles brave_rewards service into the browser. It pull the latest bat-native-anonize, bat-native-tweetnacl and bat-native-ledger into the project. The bat-native-anonize is still under security review.
It has not been tested thoroughly though. Thanks,
Resolves brave/brave-browser#1165
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: