Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total balance shows negative amount for a new wallet #1285

Closed
srirambv opened this issue Sep 26, 2018 · 2 comments · Fixed by brave/brave-core#409
Closed

Total balance shows negative amount for a new wallet #1285

srirambv opened this issue Sep 26, 2018 · 2 comments · Fixed by brave/brave-core#409

Comments

@srirambv
Copy link
Contributor

Description

Total balance shows negative amount

Steps to Reproduce

  1. Build from source and enable Rewards
  2. Claim Token grant should add 20 BAT to wallet (currently hardcoded to 10 BAT)
  3. Fund wallet with 10 BAT, Total wallet summary should show up as 30 BAT
  4. Set monthly budget to 15BAT
  5. Rewards summary shows Token Grant as 10 BAT (expected due to hardcoded value), Brave Auto-Contribute shows -10BAT (added funds to wallet), Total shows -5BAT (doesn't make sense considering wallet with added funds and hardcoded grant value should add up to 20BAT and monthly budget is set to 15 BAT)

Actual result:

Monthly budget - 15 BAT
Added Funds - 10BAT
Grant claimed - 20 BAT (hardcoded to 10BAT)
image
Monthly budget - 10 BAT
Added Funds - 10BAT
Grant claimed - 20 BAT (hardcoded to 10BAT)
image

Expected result:

Total should only show negative value if the combined value of Added funds + Grant claims is below the monthly budget.

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.2 Chromium: 70.0.3538.22 (Official Build) (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Linux

image

Reproducible on current release:

N/A for b-l

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@brave/legacy_qa @jenn-rhim @alexwykoff @davidtemkin @NejcZdovc

@srirambv srirambv added this to the 1.0 milestone Sep 26, 2018
@srirambv
Copy link
Contributor Author

@kjozwiak @LaurenWags This scenario should be retested once #948 is merged

@LaurenWags
Copy link
Member

LaurenWags commented Oct 13, 2018

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
  • Total is no longer displayed in this panel

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Verification passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants