Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use probi for reports #409

Merged
merged 6 commits into from
Oct 10, 2018
Merged

Use probi for reports #409

merged 6 commits into from
Oct 10, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 6, 2018 •
edited
Loading

Resolves brave/brave-browser#948
Resolves brave/brave-browser#1285
Resolves brave/brave-browser#1472

Ledger implementation: brave-intl/bat-native-ledger#86
UI implementation: brave/brave-ui#187

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards
  • claim grant
  • make sure that wallet summary reflects all data correctly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Sep 6, 2018
@NejcZdovc NejcZdovc changed the title Use probi for reports WIP Use probi for reports Sep 6, 2018
@NejcZdovc NejcZdovc mentioned this pull request Sep 6, 2018
Merged
@bbondy bbondy changed the title WIP Use probi for reports WIP: Use probi for reports Sep 8, 2018
@NejcZdovc NejcZdovc force-pushed the reports-probi branch 4 times, most recently from 4128d21 to 4e403ae Compare October 1, 2018 22:09
@NejcZdovc NejcZdovc force-pushed the reports-probi branch 4 times, most recently from e11989b to 2defc10 Compare October 8, 2018 04:11
@NejcZdovc
Copy link
Contributor Author

blocked on brave/brave-ui#187

@NejcZdovc NejcZdovc changed the title WIP: Use probi for reports Use probi for reports Oct 8, 2018
@NejcZdovc NejcZdovc force-pushed the reports-probi branch 2 times, most recently from 95216f9 to 50a51d8 Compare October 8, 2018 13:59
@diracdeltas
Copy link
Member

should this have unit tests for the utils?

diracdeltas
diracdeltas previously requested changes Oct 9, 2018
View reviewed changes
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok to me, requesting tests

@NejcZdovc NejcZdovc dismissed diracdeltas’s stale review October 10, 2018 11:48

@diracdeltas test added for utils like we talked 58b4a6c

NejcZdovc
NejcZdovc commented Oct 10, 2018
View reviewed changes
browser/ui/webui/brave_rewards_ui.cc
newReport->SetDouble("contribute", oldReport.auto_contribute);
newReport->SetDouble("donations", oldReport.recurring_donation);
newReport->SetDouble("oneTime", oldReport.one_time_donation);
newReport->SetString("opening", oldReport.opening_balance);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list was updated so that it matches names and fields from https://github.com/brave/brave-ui/blob/2fb8c297371056e898ae9dc2abb137fc88c50973/src/features/rewards/walletSummary/index.tsx#L27

riastradh-brave
riastradh-brave approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@riastradh-brave riastradh-brave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 30e8b42 into master Oct 10, 2018
@NejcZdovc NejcZdovc deleted the reports-probi branch October 10, 2018 20:29
NejcZdovc added a commit that referenced this pull request Oct 10, 2018
@NejcZdovc
Merge pull request #409 from brave/reports-probi
9b2a395 
Use probi for reports
NejcZdovc added a commit that referenced this pull request Oct 10, 2018
@NejcZdovc
Merge pull request #409 from brave/reports-probi
a505b1c 
Use probi for reports
@NejcZdovc
Copy link
Contributor Author

master 30e8b42
0.56 9b2a395
0.55 a505b1c

@NejcZdovc NejcZdovc mentioned this pull request Oct 16, 2018
Closed
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riastradh-brave riastradh-brave riastradh-brave approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@gdregalo gdregalo Awaiting requested review from gdregalo

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

@diracdeltas diracdeltas Awaiting requested review from diracdeltas

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.55.x - Release
4 participants
@NejcZdovc @diracdeltas @riastradh-brave @bbondy