Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie the query filter to Shields status #13242

Closed
fmarier opened this issue Dec 17, 2020 · 2 comments
Closed

Tie the query filter to Shields status #13242

fmarier opened this issue Dec 17, 2020 · 2 comments

Comments

@fmarier
Copy link
Member

fmarier commented Dec 17, 2020

As suggested in #4239 (comment) and #4239 (comment), we could tie the query filter to whether or not Shields are enabled on the destination URL.

This would enable web developers to test their trackers without needing another browser, and it would make it possible to add more generic-looking query parameters (e.g. #8975).

@stephendonner
Copy link

stephendonner commented Mar 3, 2021

Verified FIXED using beta and the testplan in brave/brave-core#7968 with

Brave 1.22.49 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.2 (Build 20D80)
  1. Open https://brave.com/?fbclid=1234 in a new tab.
  2. Check that the fbclid query parameter is missing from the URL bar.

Screen Shot 2021-03-02 at 5 00 56 PM

  1. Turn Shields OFF for brave.com.
  2. Open https://brave.com/?fbclid=5678 in a new tab.
  3. Check that the fbclid query parameter is present in the URL bar.

Screen Shot 2021-03-08 at 10 27 01 AM

  1. Turn Shields ON for brave.com.
  2. Open https://brave.com/?__s=abcd in a new tab.
  3. Check that the __s query parameter is missing from the URL bar.

Screen Shot 2021-03-02 at 4 54 55 PM


Verification passed on

Brave 1.22.53 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7968

Shields on, https://brave.com/?fbclid=1234
image

Shields off, https://brave.com/?fbclid=5678
image

Shields on, https://brave.com/?__s=abcd
image


Verification passed on


Brave | 1.22.56 Chromium: 89.0.4389.72 (Official Build) dev (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)


Verified test plan from brave/brave-core#7968

Shields on, https://brave.com/?fbclid=1234
image

Shields off, https://brave.com/?fbclid=1234
image

Shields on, https://brave.com/?__s=abcd
image

@srirambv
Copy link
Contributor

srirambv commented Mar 9, 2021

Verification passed on OnePlus 6T with Android 10 running 1.22.54 x64 beta build

Android.ARM.mp4

Verification passed on Samsung Tab A with Android 10 running 1.22.54 x64 beta build

Android.Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants