Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to manually trigger garbage collection from brave://ipfs #13554

Closed
bbondy opened this issue Jan 13, 2021 · 6 comments · Fixed by brave/brave-core#8005
Closed

Add a way to manually trigger garbage collection from brave://ipfs #13554

bbondy opened this issue Jan 13, 2021 · 6 comments · Fixed by brave/brave-core#8005

Comments

@bbondy
Copy link
Member

bbondy commented Jan 13, 2021

See the implementation notes from: #13528
It would be similar, this would allow people to trigger garbage collection when they want to.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 4, 2021

@spylogsster @bbondy I am getting the below error, not sure if this is expected.

Screen Shot 2021-03-04 at 10 53 54 AM

Generally I can't seem to get anything but the above error. STR I am using are:

  1. Clean profile with 1.22.51 (Beta)
  2. Visit an ipfs:// url such as ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  3. Join from the page shown, wait until expected ipfs url loads
  4. Open a new tab and visit brave://ipfs - see info in Repo Stats populated
  5. Click on Perform a garbage collection sweep --> get above error

Above steps produce the same error when using 1.23.17 (Nightly) as well.

Are these steps correct? I was expecting that at least Objects and Size under Repo Stats would decrease, but that's not occurring. Is there some other test plan I should be following instead - if so, could you please provide it? Thanks.

@LaurenWags LaurenWags added QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 4, 2021
@stephendonner
Copy link

@LaurenWags thanks for adding QA/Blocked, and sorry I didn't add it when filing #14355, which covers your issue, at least in part.

@LaurenWags
Copy link
Member

np @stephendonner 👍🏻 will leave as Blocked until we confirm the test plan.

@spylogsster
Copy link

spylogsster commented Mar 9, 2021

@LaurenWags your steps are correct, would be better to visit more sites to increase storage usage and then it will be decreased when you press the button.
We found the reason of error here #14355 (comment)

@LaurenWags
Copy link
Member

LaurenWags commented Mar 9, 2021

thanks @spylogsster, I made a note of that suggestion on the follow up issue so we can incorporate that when we test the follow up issue.

also, changed this issue from release-notes/include to release-notes/exclude since issue is not fixed and will be handled via the follow up issue logged by @stephendonner. please adjust if needed @rebron @kjozwiak .

@LaurenWags
Copy link
Member

LaurenWags commented Mar 9, 2021

Verified using

Brave | 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H524)

As per #13554 (comment) and #13554 (comment) garbage collection does not work due to #14355 (comment).

Follow up issue #14355 logged by @stephendonner, testing will be performed with that issue once it is resolved.


Verification passed on


Brave | 1.22.56 Chromium: 89.0.4389.72 (Official Build) dev (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)


Verification passed on

Brave 1.22.58 Chromium: 89.0.4389.86 (Official Build) beta (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants