-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some of Brave's Default Shields settings breaking extensions #1380
Comments
+1 from Community: https://community.brave.com/t/lastpass-issues-persist-in-beta/33932/2 |
Another from Community : https://community.brave.com/t/unable-to-log-in-to-the-grammarly-extension/34011**** |
+1 from Community with Soapbox extension from Wistia https://community.brave.com/t/soapbox-from-wistia-cant-log-in/34306?u=eljuno |
+1 from Community: https://community.brave.com/t/new-tab-redirect/34855/8 With this extensions the "Allow all Cookies" workaround does not resolve the issue. |
+1 from https://community.brave.com/t/shield-settings-for-extensions/35957 for Todoist Extension and the Gmail extension |
I have also reproduced this issue when trying to sync my account with the YayAnotherSpeedDial extension (https://github.com/Mimiste/YayAnotherSpeedDial). I can log in successfully, but no data is synced after login, and opening a new tab requires signing in again. As @srirambv suggested on the community board, allowing all cookies fixes the log in persistence bug, but this is a suboptimal solution. |
+1 (of many ) from Community: |
Agreed, once we start migrating users in |
Has this been re-tested since the cookie fix with PDFJS? I tested the first 2 extensions in the first comment with dev channel and they both work. I think if you use a 0.57.x build it will work too. @Brave-Matt @kjozwiak @srirambv pls confirm. |
@bbondy, sorry for the late reply. Evernote WC - Extension works only if All Cookies Allowed is set in Global Shields More info: I'm also unable to edit the options for Evernote unless all cookies are allowed (global) Diigo - Extension works as expected with Global Shields set to default Grammarly - Extension does work, but I'm unable to login to the extension. That is, the extension alerts me that Grammarly is active but features aren't present because I'm not logged in. When I click "login" it brings me to the Grammarly page, I log in, return to extension - no change. This is with Global and site Shields turned off or on. Todoist - Functions but only when all cookies are allowed globally Notifier for gmail - Does not work. Regardless of Shields settings, extension will not display new emails, unread emails, inbox count, or even display as active (extension is colored when active, grayed out if not). Yayanotherspeedial - Works if you click the extension and to open the YASD new tab page. However, it does not override the new tab page (likely related to #993 so hopefully fixed soon) Hangouts - Extension doesn't work unless all cookies allowed (global). Otherwise, prompted to login, but login page never loads. Pocket - To my surprise, works great with default Shields. Additional (known to be) broken extensions not yet tested:
Question: |
+1 for Mixmax Gmail integration does not work (tested in 0.58.9), "Allow all cookies" fixes it in the meantime. |
Fix to disable this is done here brave/brave-core#975 |
The reasoning is they have APIs to do much worse tracking than our shields would protect them from. Users install them knowing they will have elevated permissions Fix brave/brave-browser#1380
Verification Passed on
Verification Passed on
|
rescuetime extension is not sending detailed information about my usage |
+1 on the Google Keep extension |
Shield also breaks the Mendely importer extension (https://chrome.google.com/webstore/detail/mendeley-importer/dagcmkpagjlhakfdhnbomgmjdpkdklff?hl=en), after trying to log in it reports I'm on version 0.61.51 on Linux |
I could not tell if this issue is supposed to be resolved in 0.57 going forward, but I am running 0.62.37 and I still get a CSRF Token mismatch when trying to use the Todoist for Gmail extension due to 3rd party cookie. |
@benmordecai you must be running a dev/beta build, correct? |
You are right I am running the beta. I am not sure if the fix is supposed to be in place on either build, but I wanted to report that if it is, I am still having the issue. |
+1 MixMax - Breaking with shields down |
Google Keep still broken in 0.62.50 |
Please post new issues, we keep 1 issue per landed area of code unless it is reverted. Thank you! |
Regarding Google Keep not working, we have #3650 opened. Please add +1's into that issue if you're having issues with Google Keep. |
Ok thanks! |
+1 (I'm on version 0.64.77 in Windows 10) |
@pmguerre can you please create a new issue regarding Once you create an issue, you can mention the bug # in here so folks looking at this issue can find the new issue relating to |
Has this been fixed? It is not allowing me to use the Evernote Clipper Extension, saying I need to allow 3rd party cookies and even if I chose to allow all cookies in Braves settings nothing changes. |
@josegocampo are you still having issues with How are you attempting to login? Email or Gmail? What are your default cookie settings for shields? If you're still having issues, can you please create a new issues similar to #3650. |
+1 for grammarly. Logs me in the website, but does not log me into the extension. |
It's 2021 and the google keep issue is still not solved... I think a lot of us are really sad about this fact |
+1 for Todoist extension, still broken as @neolit proved. |
Description
I realize that this may seem obvious since this was a common issue with the pre-installed extensions in Browser-Laptop but given that Brave-Core allows for all Extensions, this problem pops up much more often and supporting/advising users on how to address the issue is slightly problematic.
Examples:
1 - Evernote Web Clipper
This extension installs without issue but breaks after attempting to sign-in to Evernote account. Sign-in is still registered/successful, but the extension cannot be used and you're presented with the following error:
2 - Diigo Web Capture - Capture and Annotate
This extension works very much in the same way as Evernote. Installs fine and even further, account sign-in works properly. However, when attempting to use the extension (for instance, clicking "Add a Bookmark", the extension displays as seen here:
The loading wheel in the top right spins infinitely. Selecting "save" closes the extension but does not actually save the content.
Both of these issues are resolved by changing Brave's default Shields settings - specifically changing the
Cookie Control
option toAllow all cookies
. Once switched, these extensions behave as expected.This occurs on both Dev and Beta versions, with or without fresh install and with or without additional extensions installed.
Steps to Reproduce
(Covered above but will simplify)
Actual result:
Function is not performed, alert message to make sure cookies are allowed is displayed.
Expected result:
Evernote function executes
Reproduces how often:
Always
Brave version (chrome://version info)
Beta - Version 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Dev - Version 0.56.1 Chromium: 70.0.3538.22 (Official Build) dev (64-bit)
Reproducible on current release:
Website problems only:
Additional Information
Initial reports:
https://community.brave.com/t/diigo-annotate-and-capture/33859
https://community.brave.com/t/evernote-web-clipper-extension/33648/4
The text was updated successfully, but these errors were encountered: