Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new permission to expose chrome.ipfs API to extensions #13998

Closed
bbondy opened this issue Feb 5, 2021 · 1 comment · Fixed by brave/brave-core#8289 or brave/brave-core#8409
Closed

Comments

@bbondy
Copy link
Member

bbondy commented Feb 5, 2021

Add a new permission for chrome.ipfs api and notify the user of this permission when they try to install a Chrome extension that has this permission.

Example for an extension that requests the permission "ipfs" we should list that they are requesting it here:
Screen Shot 2021-03-17 at 4 08 34 PM

This extension ID is currently published to the chrome store with the ipfs permission for testing:
fpeoodllldobpkbkabpblcfaogecpndd

https://chrome.google.com/webstore/detail/webrecorder-archivewebpag/fpeoodllldobpkbkabpblcfaogecpndd

This is a talk by the same author that would like this API:
https://www.youtube.com/watch?v=evcSETnTBf0

so basically the task is in 2 parts, and 1) is needed before we are allowed to do 2)

  1. Show IPFS info in that screenshot above about IPFS
  2. Give chrome.ipfs access to any extension that requests it
@bbondy bbondy added priority/P4 Planned work. We expect to get to it "soon". feature/web3/ipfs OS/Desktop labels Feb 5, 2021
@spylogsster spylogsster self-assigned this Mar 18, 2021
@spylogsster spylogsster added this to the 1.24.x - Nightly milestone Mar 29, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 5, 2021
@stephendonner
Copy link

Verified PASSED using the testplan from brave/brave-core#8289

Brave 1.24.47 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS macOS Version 11.2.3 (Build 20D91)

Steps:

  1. Installed extension with ipfs permission in the manifest file, for example https://chrome.google.com/webstore/detail/webrecorder-archivewebpag/fpeoodllldobpkbkabpblcfaogecpndd
  2. Confirmed alert about IPFS in permission bubble

Screen Shot 2021-04-05 at 11 52 26 AM

  1. Went to chrome://inspect#extensions and inspected Webrecorder background page

Screen Shot 2021-04-05 at 12 00 10 PM

  1. Checked that namespace chrome.ipfs has only 3 public methods available

Screen Shot 2021-04-05 at 11 40 32 AM

  1. Checked the same for Brave Shield extension, all ipfs methods should be available

Screen Shot 2021-04-05 at 11 48 23 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants