-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ipfs api permission rule #8289
Conversation
6184e2b
to
11c38c3
Compare
11c38c3
to
3b8450b
Compare
patches/chrome-common-extensions-permissions-chrome_permission_message_rules.cc.patch
Outdated
Show resolved
Hide resolved
patches/chrome-common-extensions-permissions-chrome_api_permissions.cc.patch
Outdated
Show resolved
Hide resolved
4bcf6ac
to
c84ba2e
Compare
chromium_src/chrome/common/extensions/permissions/chrome_api_permissions.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/common/extensions/permissions/chrome_api_permissions.cc
Outdated
Show resolved
Hide resolved
chromium_src/chrome/common/extensions/permissions/chrome_api_permissions.cc
Outdated
Show resolved
Hide resolved
62afc76
to
e085bb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
and patches
changes LGTM 👍
cd70d6b
to
28ad64e
Compare
2e22d09
to
464a042
Compare
Exposed 3 API for external extensions with confirmed
others will be available only for allowlisted ones (ipfs-companion, ipfs-companion-beta, Brave Shields) cc @bbondy |
77254d2
to
b88d721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but have a question before I approve.
8b1114f
to
d53bf10
Compare
d53bf10
to
9896518
Compare
Resolves brave/brave-browser#13998
Add a new permission rule to expose chrome.ipfs API to extensions
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: