Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ipfs api permission rule #8289

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Added ipfs api permission rule #8289

merged 1 commit into from
Mar 29, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 18, 2021

Resolves brave/brave-browser#13998

Add a new permission rule to expose chrome.ipfs API to extensions

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@spylogsster spylogsster force-pushed the add-ipfs-permission branch 4 times, most recently from 4bcf6ac to c84ba2e Compare March 19, 2021 11:39
@spylogsster spylogsster force-pushed the add-ipfs-permission branch 4 times, most recently from 62afc76 to e085bb8 Compare March 19, 2021 15:50
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src and patches changes LGTM 👍

@spylogsster spylogsster force-pushed the add-ipfs-permission branch 7 times, most recently from cd70d6b to 28ad64e Compare March 22, 2021 12:57
@spylogsster spylogsster force-pushed the add-ipfs-permission branch 6 times, most recently from 2e22d09 to 464a042 Compare March 24, 2021 10:31
@spylogsster
Copy link
Contributor Author

spylogsster commented Mar 24, 2021

Exposed 3 API for external extensions with confirmed ipfs permission:

  • ipfs.getIPFSEnabled
  • ipfs.resolveIPFSURI
  • ipfs.getResolveMethodType

others will be available only for allowlisted ones (ipfs-companion, ipfs-companion-beta, Brave Shields)

cc @bbondy

@spylogsster spylogsster force-pushed the add-ipfs-permission branch 4 times, most recently from 77254d2 to b88d721 Compare March 26, 2021 12:27
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but have a question before I approve.

@spylogsster spylogsster force-pushed the add-ipfs-permission branch 2 times, most recently from 8b1114f to d53bf10 Compare March 29, 2021 06:57
@bbondy bbondy merged commit 0d3c829 into master Mar 29, 2021
@bbondy bbondy deleted the add-ipfs-permission branch March 29, 2021 17:11
@spylogsster spylogsster added this to the 1.24.x - Nightly milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new permission to expose chrome.ipfs API to extensions
4 participants