Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l18N text shown for all labels on BAT button dropdown #1424

Closed
srirambv opened this issue Oct 4, 2018 · 4 comments · Fixed by brave/brave-core#604
Closed

l18N text shown for all labels on BAT button dropdown #1424

srirambv opened this issue Oct 4, 2018 · 4 comments · Fixed by brave/brave-core#604
Assignees
@bbondy
Labels
feature/rewards l10n OS/Windows QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 4, 2018 •
edited
Loading

Description

l18N text shown for all labels on BAT button dropdown

Steps to Reproduce

  1. Upgrade to 0.55.11
  2. Enable Brave Rewards
  3. BAT dropdown has l18N for all labels

Actual result:

image
image

Expected result:

Should not show l18N for any lables

Reproduces how often:

100%

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? NA
  • Does it reproduce on browser-laptop? N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added this to the Releasable builds 0.55.x milestone Oct 4, 2018
@NejcZdovc
Copy link
Contributor

@bridiver could you please check why it's not loading language file on windows. Thank you

@srirambv srirambv mentioned this issue Oct 4, 2018
Closed
@LaurenWags
Copy link
Member

Could not reproduce on macOS using

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

@NejcZdovc NejcZdovc assigned bbondy and unassigned bridiver Oct 10, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 10, 2018 •
edited by bbondy
Loading

[edit bbondy: work related to this is]
done in brave/brave-core@6037502 and brave/brave-core@5111c94

@bbondy bbondy added the QA/Yes label Oct 10, 2018
@srirambv srirambv mentioned this issue Oct 11, 2018
Closed
@bbondy bbondy mentioned this issue Oct 11, 2018
Merged
18 tasks
bbondy added a commit to brave/brave-core that referenced this issue Oct 11, 2018
@bbondy
Copy brave_rewards locales to mini installer staging area
70f68ed 
Fix brave/brave-browser#1424
@btlechowski
Copy link

Verification passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/rewards l10n OS/Windows QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Copy brave_rewards locales to mini installer staging area brave/brave-core
6 participants
@bridiver @bbondy @NejcZdovc @srirambv @LaurenWags @btlechowski