Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip initialization of referral system for the default referral code #14428

Closed
bsclifton opened this issue Mar 2, 2021 · 3 comments · Fixed by brave/brave-core#8103
Closed

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 2, 2021

Test plan

See brave/brave-core#8103

Background

Originally added in brave/brave-core#1982 (to address #2547), Brave will default to promo code BRV001.

We have since sunset the referral program (see https://brave.com/referral-program-update/) except for a few specific cases. For more information on how the referral program works please see https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes

Description

We should skip initialization of the referral system for the default code (BRV001)

@bsclifton bsclifton added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 2, 2021
@bsclifton bsclifton self-assigned this Mar 2, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Mar 2, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Mar 2, 2021
@bsclifton bsclifton changed the title Remove default referral code Don't initialize referral system for the default code Mar 2, 2021
@bsclifton bsclifton changed the title Don't initialize referral system for the default code Don't initialize referral system unless a real referral code is provided Mar 2, 2021
@bsclifton bsclifton changed the title Don't initialize referral system unless a real referral code is provided Skip initialization of referral system for the default referral code Mar 2, 2021
@kjozwiak kjozwiak added this to the 1.21.x - Release milestone Mar 2, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2021

As per conversation with @BrendanEich @bsclifton and others, we'll want to get this into 1.21.x. Adding release/blocking.

@srirambv
Copy link
Contributor

srirambv commented Mar 3, 2021

Verification passed on OnePlus 6T with Android 10 running 1.21.73 x64 build

  • Verified able to see the referral id under nonua on 1.20.108 build
    image
  • Verified /promo/initialize/nonua wasn't called on startup when running 1.21.73
    image
  • Verified brave://local-state contains BRV001 for referral code even when /promo/initialize/nonua is removed
    image
  • Verified download_id is not present in brave://local-state via the referral header
    image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 3, 2021

Verification passed on

Brave | 1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

  • Verified using Charles Proxy that I can no longer see the referral_code: BRV001 section in a JSON blob under initalize, nonua, as I can, with release build 1.20.110, for the host https://laptop-updates.brave.com/.
  • Verified that the BRV001 referral was being used in brave://local-state
1.20.110 1.21.73 Referral/promo code via brave://local-state 1.21.73
image image image

Verification passed on

Brave 1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8103 (comment)

image


Verified passed with

Verified test plan from brave/brave-core#8103 (comment)

  • ensured that /promo/initialize/nonua wasn't being called at startup as per the examples below
  • ensured that the BRV001 referral was being used in brave://local-state
Before (1.21.71) After (1.21.73) Referral code via brave://local-state (1.21.73)
1 21 71 1 21 73 - 2 1 21 73 - 2 copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment