Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS: My Node button should be a different color from Start/Stop/Restart buttons #14452

Closed
stephendonner opened this issue Mar 3, 2021 · 2 comments · Fixed by brave/brave-core#8464

Comments

@stephendonner
Copy link

stephendonner commented Mar 3, 2021

Description

IPFS: My Node button should be a different color from Start/Stop/Restart buttons

Steps to Reproduce

  1. new profile, launch Brave
  2. load brave://ipfs
  3. click the Install and start button
  4. note the color of the My Node button

Actual result:

My Node is the same blueish color as the Start/Stop/Restart buttons.

Screen Shot 2021-03-03 at 9 32 08 AM

Expected result:

According to #13173 (comment), the button color for My Node should be different from the Start/Stop/Restart buttons

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.22.51 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.2 (Build 20D80)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc: @jessicaschilling @spylogsster @karenkliu - probably Karen has UI insight, here?

@karenkliu
Copy link

This should use our shared frontend button component:

image

@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.25.2 Chromium: 90.0.4430.51 (Official Build) nightly (x86_64)
Revision 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS macOS Version 11.2.3 (Build 20D91)

Looks just like the mockup from @karenkliu in #14452 (comment)

Screen Shot 2021-04-07 at 3 53 08 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants