Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up to #12203 add No button or Do not ask again option to show default browser dialog #14469

Closed
rebron opened this issue Mar 4, 2021 · 30 comments · Fixed by brave/brave-core#8253 or brave/brave-core#8474

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 4, 2021

Description

Default browser dialog prompt frequency may be too aggressive with asks on 2nd, 3rd, and 4th launches (and finally 8th and 20th launches). Consider adding a No button or Do not ask again as option to never ask again. Alternatively, could consider removing 3rd ask.

Steps to Reproduce

See test plan:
brave/brave-core#7716

Expected result:

image-2

"No" or "Never ask again" option, alternatively less frequent ask.

Reproduces how often:

Brave version (brave://version info)

Brave | 1.21.73

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron changed the title follow-up to #12203 add No button or Do not ask again option to this dialog follow-up to #12203 add No button or Do not ask again option to show default browser dialog Mar 4, 2021
@rebron
Copy link
Collaborator Author

rebron commented Mar 4, 2021

cc: @simonhong @bsclifton

@emarsk
Copy link

emarsk commented Mar 4, 2021

So, does it stop eventually? Because I'm back to Chrome if it doesn't. And I hope the counter doesn't ever get reset.

It should ask just the first time, if ever.

@karenkliu
Copy link

@rebron @bsclifton Let's remove the 3rd launch ask so it doesn't feel like it's asking every time.

So 2nd, 4th, 8th, 20th launch.

@nmarley
Copy link

nmarley commented Mar 4, 2021

Can you please just give us an option to never see this again? Asking every 2nd, 4th, 8th... seems very annoying still.

@karenkliu
Copy link

karenkliu commented Mar 4, 2021

We think you might change your mind if you have more time to experience Brave 😉

// EDIT // ☝️ This was meant to be playful snark; not a callous shrugging off of everyone's feedback. Sorry! That probably didn't come through clearly in written form.

@nmarley
Copy link

nmarley commented Mar 4, 2021

We think you might change your mind if you have more time to experience Brave 😉

I've been using Brave for a year or two now, but don't want to make it default. And my current experience is not encouraging.

Are those our only options? Either endure the "Make this default" nags or just don't use Brave?

@karenkliu
Copy link

karenkliu commented Mar 4, 2021

@nmarley We're definitely keeping an eye out for more feedback like yours about this newly introduced 'set default browser' nag and will tweak the experience.

I'm curious though - aside from the default browser nag, what's the main issue you've seen with Brave in the past couple years that turns you off from using Brave as your daily driver?

@zmre
Copy link

zmre commented Mar 4, 2021

My default browser is actually a browser chooser. I use different browsers for different purposes. Brave is my default for some things, but not everything. For example, I use site specific browsers for some sites to isolate them from a privacy perspective and to allow me to alt-tab to them. And that's how I want it to stay.

As I close browsers regularly, I'm seeing this nag multiple times in the same day, which is exceptionally annoying.

It's good to know that it will eventually stop, but your UI didn't clue me into the fact that the nag won't last forever, which made me think this was going to be a perpetual problem. I don't think you want your other users thinking the same thing.

Please consider a "Don't Ask Again" option or, worst case if you can't get on board with that, give some info explaining that you'll only ask X more times before the nag stops.

And now I'm going to go launch/quit/launch/quit until I get back to the happy place. Then I'll hope the counter doesn't reset after the next update.

@davidgsd
Copy link

davidgsd commented Mar 4, 2021

Do Brave developers really think people need to be asked nunerous times in a row, 8th, 20th etc. ad nauseum and presumably after every Brave update? This kind of assumption on the part of developers - that users are not savvy enough to decide by themselves which browsers they want to use and which they want to be the default without being asked 5 times will definitely become a self-fulfilling prophecy as savvier users look for other options, after wasting 15 minutes of their day to disable this ridiculous nag which apparently has no disable option in the settings. This is not user-friendly design. Thank you

@JuanCab
Copy link

JuanCab commented Mar 4, 2021

Its particularly irritating that since Brave has gone through a few updates recently, it seems to "reset" the default browser check. I also use a browser chooser and frankly, I have zero interest in ANY browser other than my chooser being the default. Please allow users to CONTROL the browser instead of forcing this dialog box up so many times.

@JuanCab
Copy link

JuanCab commented Mar 4, 2021

@rebron @bsclifton Let's remove the 3rd launch ask so it doesn't feel like it's asking every time.

So 2nd, 4th, 8th, 20th launch.

No, no, no. Please only ask one time. Being aggressive like this is a BIG turn off and inconsistent with the behavior people expect from browsers. If you keep asking, users will assume the setting isn't 'sticking' and will think Brave is buggy in this regard. Honestly, its what I thought which is why I came to github to report it as an error!

If you want to break the standard operating procedure used by other browsers and plan on re-asking several times, you really checkbox saying "Don't ask again." This makes it clear to the user that saying "not now" isn't enough to truly turn off the feature.

I really suspect if you don't do something like this, people will keep reporting this behavior as 'buggy' in the future.

@karenkliu
Copy link

I hear you - all of this feedback is welcome and helpful. As mentioned, we're definitely keeping tabs on feedback like this and will tweak the experience.

presumably after every Brave update

☝️ The counter should not be resetting after every update, so if this is happening it's a bug.

@ocdtrekkie
Copy link

Removing the ability to disable default browser nags is vehemently anti-user, and shows a surprising choice to be more user hostile than Google manages to be.

The answer is simple: The same place in settings where the option to make it default exists, must also be a single option to disable it asking. Every other browser has this. Yours doesn't. Fix it.

@rebron
Copy link
Collaborator Author

rebron commented Mar 5, 2021

@ocdtrekkie "Vehemently" more user hostile than Google? Really? That one hurts. Issue has been filed, work and fix is underway. In the meantime, launch Brave 21 times as the quick workaround, and I'm not being facetious as I get that this type of dialog prompt can be deeply annoying.

There's always a cognitive load when there's several choices to a dialog, here it would be three "not now", "set as default" and adding a third "don't show again" and having the three options isn't always the best choice. We went with ask five times and don't ever show again. In other places like with widevine component or presenting an option for translations, we went with the three options as those would show in context every time.

@ocdtrekkie
Copy link

If you ask someone the same question more than once, it means you aren't taking no for an answer, @rebron. Asking more than once, for that matter, five times, is a statement of disrespect.

Please remember that your users know what they want. If they wanted Brave to be the default, they'd do so the first time you ask. Or, they'd go into browser Settings and click the button there. Or their OS' default apps settings page. Sure, maybe asking one more time after the user has had time to spend with the browser might be defensible, but five is not.

Remember that for every default user a repetitive ask has gained you, you burned your reputation and goodwill with others, possibly irreparably, in exchange.

@zmre
Copy link

zmre commented Mar 5, 2021

For what it's worth, I think Safari asks once per version. It's vaguely annoying, but not a huge deal since they don't update all that often.

Brave's approach bothered me in part because I was repeatedly saying no in a single day.

It bothered me enough that I checked preferences and then when Internet hunting for a fix.

In finding this thread, I found a workaround, but the whole magic "open it 21 times to fix the problem" thing is something I wouldn't wish on anyone. And I did it. Also, that magic number isn't communicated in the app. And whatever cognitive load was saved by removing a button choice was eaten up many times over in trying to find a way to stop the nagging.

I think of Brave's user base as being more technically sophisticated than average. Possibly I'm way off base on that, but regardless, it doesn't feel like you're giving your users much credit here.

I'm writing this in the hopes that it will persuade you to do more than just tweak the nag intervals. The problem is solved for me, but I hope to save others from a similarly negative experience.

@rebron
Copy link
Collaborator Author

rebron commented Mar 5, 2021

@zmre I appreciate the feedback and sharing your use case (and using Brave multiple times in a day it seems like). We're getting to a point where we are attracting more mainstream users and we want to remind them about this setting. Being in settings at all is by definition buried and this is one of the important ones we do want to highlight.

It's clear the ask is a "no" or "do not ask again option" (both will mean the same thing as don't show again) and that's how I've labelled the issue and that's what we're exploring. A negative user experience is not what we want.

@ocdtrekkie I can see persistent (in the positive) or annoying or overly aggressive (in the negative). Disrespectful? I really hope not. I hope we haven't irreparably lost you as a user because of this dialog and that on your own you'll make us your default browser. Earning goodwill is tough, I agree.

@zpcc
Copy link

zpcc commented Mar 5, 2021

The counter seems not working if I start brave.exe with --incognito. And I think a 'No' button is really necessary.

@metalim
Copy link

metalim commented Mar 5, 2021

Was looking for a method to turn off those annoying notifications, found this thread. Discussion is hilarious, authors believing it's good to ask for acceptance on 2nd, 3rd, 4th, 8th AND 20th launch is beyond my understanding of how user loyalty should be acquired. Good luck, guys.

@githubmarker
Copy link

Agreed with others.
Asking a YES/NO question and only giving the user a "Not Now" option is impolite.

As a random sample of user frustration and confusion, here's a thread created yesterday.
https://www.reddit.com/r/BATProject/comments/lxt36b/brave_asking_to_be_default_again/

I came across it while searching for: brave stop asking default.
It wasn't that helpful, which is why my next search was: brave github issues.

@bbondy
Copy link
Member

bbondy commented Mar 5, 2021

We're sorry for the misstep, we'll get it fixed, landed, uplifted to release channel, and released to production asap 👍

@rebron
Copy link
Collaborator Author

rebron commented Mar 5, 2021

We're working on a two step fix for this:

  1. Only asking twice follow-up to #12203 reduce dialog frequency to display twice #14502 on 3rd and 20th browser opens. Fix in release soon.
  2. Adding Do not show again checkbox when we show additional times. Prelim designs added.
    https://user-images.githubusercontent.com/5951041/110162210-45da2e80-7da3-11eb-9ddd-bf0763e51051.png

@ocdtrekkie
Copy link

3rd and 20th sounds good to me. That's not obnoxious, and the checkbox is good too.

Thanks!

@raymondyew
Copy link

raymondyew commented Mar 5, 2021

I use different browsers for different stuff (one for work, one for emails/personal stuff, one for youtube/news/fun stuff). The brave default browser popup annoys me because I use it for youtube/news/funstuff and I don't want opening links for work to popup in brave instead of my work browsers.

Great to see you peeps at brave being transparent on what you're doing. 😊

@aa956
Copy link

aa956 commented Mar 8, 2021

Although complete and final opt-out option would be ideal it would be nice to document this behavior, e.g. in the popup itself, something like this:

Set Brave as your default browser

We're asking this question 2nd time out of 8 total
[Not now] [Set as default]

Reason for request for additional explanation in the dialog itself is that seeing this popup first few times I've tried to uninstall and reinstall the Brave to get rid of the popup suspecting malicious extension (using different browsers for different tasks: work, personal, legacy web application etc. and will not change the default one that is not Brave).

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 9, 2021
@VAggrippino
Copy link

Every other browser has a checkbox that can be unchecked, labeled something like Always check if Brave is my default browser. "Playful snark" my ---... This was a conscious decision to irritate users.

@LodeHere
Copy link

LodeHere commented Mar 13, 2021

After some years of enjoying Brave as a most user friendly browser with many options to customize it -which I have done to exactly my taste- the sudden appearance of the constant question if I want to make Brave my default browser feels like a an aggressive Foot-in-the-Door sales tactic.
Every time you say politely "No, thank you" to the salesman he rings your doorbell again and when you open he again puts his foot in your door.... .

The thought has passed my mind to uninstall Brave and check now and then if that trick has stopped. So I can install Brave again without the frustration felt every time I open that otherwise great browser.

I bet many other users feel the same way about it, but don't bother to go to a forum -many even first having to become a member- to express what they think and feel about this.

simonhong added a commit to brave/brave-core that referenced this issue Mar 15, 2021
Default browser prompot is disabled if it's checked.

fix brave/brave-browser#14469
simonhong added a commit to brave/brave-core that referenced this issue Apr 5, 2021
Default browser prompot is disabled if it's checked and user
will not see this prompt anymore.
This checking is stored in local state so new profile also can't see
this prompt dialog anymore.

fix brave/brave-browser#14469
simonhong added a commit to brave/brave-core that referenced this issue Apr 5, 2021
Default browser prompot is disabled if it's checked and user
will not see this prompt anymore.
This checking is stored in local state so new profile also can't see
this prompt dialog anymore.

fix brave/brave-browser#14469
@simonhong simonhong added this to the 1.24.x - Nightly milestone Apr 6, 2021
simonhong added a commit to brave/brave-core that referenced this issue Apr 7, 2021
@stephendonner
Copy link

stephendonner commented Apr 14, 2021

Hi @simonhong I extended and modified the testplan you posted in brave/brave-core#8253, for a few more scenarios/combinations; mind taking a look and providing feedback here? Thanks in advance!


Verified PASSED using

Brave 1.24.63 Chromium: 90.0.4430.70 (Official Build) beta (x86_64)
Revision 3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS macOS Version 11.2.3 (Build 20D91)

Scenario One - Not now (button)

  1. set Chrome as the default browser
  2. new profile for Beta
  3. launch Brave Beta (1st)
  4. uncheck Set Brave as your default browser
  5. click the Start Brave button
  6. click on the Skip welcome tourlink and create a new-tab page
  7. shut down and relaunch Brave Beta
  8. shut down and relaunch Brave Beta (3rd)
  9. confirm you get Set Brave as your default browser prompt
  10. click the Not now button
  11. shut down and relaunch Brave Beta 17 more times
  12. confirm you get Set Brave as your default browser prompt (20th launch)
  13. continue to shut down and relaunch Brave Beta a few more times
  14. confirm you no longer get prompted to set Brave as your default browser

Scenario Two - Don't ask again (checkbox)

  1. set Chrome as the default browser
  2. new profile for Beta
  3. launch Brave Beta (1st)
  4. uncheck Set Brave as your default browser
  5. click the Start Brave button
  6. click on the Skip welcome tourlink and create a new-tab page
  7. shut down and relaunch Brave Beta
  8. shut down and relaunch Brave Beta (3rd)
  9. confirm you get Set Brave as your default browser prompt
  10. click on [x] Don't ask again
  11. click on Not now
  12. shut down and relaunch Brave Beta 17 more times
  13. confirm you no longer get prompted to set Brave as your default browser

Scenario Three - Don't ask again (checkbox), multiple profiles

  1. set Chrome as the default browser
  2. new profile for Beta
  3. launch Brave Beta (1st)
  4. uncheck Set Brave as your default browser
  5. click the Start Brave button
  6. click on the Skip welcome tourlink and create a new-tab page
  7. shut down and relaunch Brave Beta
  8. shut down and relaunch Brave Beta (3rd)
  9. confirm you get Set Brave as your default browser prompt
  10. click on [x] Don't ask again
  11. click on Not now
  12. shut down and relaunch Brave Beta 17 more times
  13. confirm you no longer get prompted to set Brave as your default browser
  14. create a new profile and close all other profiles
  15. launch Brave Beta a few more times using the new profile
  16. confirm you no longer get prompted to set Brave Beta as your default browser

Scenario Four - Set as default (button)

  1. set Chrome as the default browser
  2. new profile for Beta
  3. launch Brave Beta (1st)
  4. uncheck Set Brave as your default browser
  5. click the Start Brave button
  6. click on the Skip welcome tourlink and create a new-tab page
  7. shut down and relaunch Brave Beta
  8. shut down and relaunch Brave Beta (3rd)
  9. confirm you get Set Brave as your default browser prompt
  10. click on the Set as default button
  11. confirm you get the Do you want to change your default browser to "Brave" or keep using "Chrome"? dialog
  12. click on the Use "Brave" button
  13. shut down and relaunch Brave Beta
  14. open brave://settings/?search=default and confirm it says Brave is your default browser
  15. shut down and relaunch Brave a few more times
  16. confirm you're never prompted for the default browser again
example example example example example example example example
Screen Shot 2021-04-14 at 5 13 28 PM Screen Shot 2021-04-14 at 5 19 00 PM Screen Shot 2021-04-14 at 5 10 36 PM Screen Shot 2021-04-14 at 5 14 19 PM Screen Shot 2021-04-14 at 5 30 07 PM Screen Shot 2021-04-14 at 5 30 24 PM Screen Shot 2021-04-14 at 5 10 55 PM Screen Shot 2021-04-14 at 5 12 14 PM

/cc @brave/legacy_qa for visibility/potential feedback, too


Verification passed on

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified the above testplan

image image image

Logged #15387


Verification passed on

Brave | 1.24.69 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified the test plan from @stephendonner and @simonhong

image image

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 14, 2021
@simonhong
Copy link
Member

@stephendonner Looks great 👍

@phineas12
Copy link

phineas12 commented Aug 20, 2021

This is still broken on Android, where it's a far more irritating full screen takeover. Been asked probably 30 times by now, although understandably now I'm using it less and less.

#17014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment