-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewards and other custom chrome:// pages need favicon #1466
Comments
Action items from @davidtemkin
|
fixes in brave/brave-core#756 |
@rossmoody @NejcZdovc could one of you add a test plan for this issue please? |
@LaurenWags test plan is quite simple. Go to rewards setting page and make sure that settings tab has rewards logo as favicon |
thanks @NejcZdovc ! Wasn't sure if other pages were included with this issue as well. |
Yeah maybe the scope of this one could be just for the rewards favico. We have a similar issue with a larger collection that might need revisited soon: #1278 |
Verification pased on
Verrification passed on Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit) Verification passed with
|
Description
Custom chrome:// pages need favicons. For pages like Rewards, which is included in the on-boarding flow, this should be done sooner rather than later, it looks bad without a favicon.
Steps to Reproduce
Actual result:
No favicon:
Expected result:
Custom pages should have favicon like welcome page.
Reproduces how often:
easy
Brave version (chrome://version info)
Reproducible on current release:
Website problems only:
Additional Information
Similar to #1278 but that issue is specific to Task Manager.
The text was updated successfully, but these errors were encountered: