Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish full variation names on brave://version #14780

Closed
iefremov opened this issue Mar 17, 2021 · 3 comments · Fixed by brave/brave-core#8699
Closed

Publish full variation names on brave://version #14780

iefremov opened this issue Mar 17, 2021 · 3 comments · Fixed by brave/brave-core#8699

Comments

@iefremov
Copy link
Contributor

iefremov commented Mar 17, 2021

For now, brave://version shows some hashed data instead of real variation names (if they exist). We should show full names.

iefremov added a commit to brave/brave-core that referenced this issue May 7, 2021
@iefremov iefremov self-assigned this May 10, 2021
@iefremov iefremov added this to the 1.26.x - Nightly milestone May 10, 2021
@iefremov iefremov changed the title Publish full variation names on brave://version and allow to opt-out Publish full variation names on brave://version May 10, 2021
@iefremov iefremov added the OS/Android Fixes related to Android browser functionality label May 10, 2021
@iefremov
Copy link
Contributor Author

iefremov commented May 10, 2021

Edited this issue to only mention full names instead of hashes. For the opt-out toggle on Desktop filed a new one #15711 (cc @moritzhaller )

@stephendonner
Copy link

stephendonner commented May 13, 2021

Verified FIXED using the steps from brave/brave-core#8699, and build

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS Windows 10 OS Version 2009 (Build 21376.1)

Steps:

  1. clean profile
  2. launch Brave
  3. restart Brave
  4. open brave://version
  5. look at the bottom Variations: section

Confirmed that my brave://version page shows the following (without cryptic hash values):

Variations: AdvertiserSplitTestStudy:GroupB
EphemeralStorageStudy:Enabled
PermissionLifetimeStudy:Enabled

variations


Verified PASSED using the steps from brave/brave-core#8699 with build

Brave 1.27.45 Chromium: 91.0.4472.88 (Official Build) nightly (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

Had the following variations:

AdServingStudy:MaximumAdNotificationsPerDay=60
AdvertiserSplitTestStudy:GroupA
BraveAds.FrequencyCappingStudy:ExcludeAdIfWithinTimeWindow=0h
BraveAds.ShowCustomAdNotificationOnMacStudy:Default
BraveAds.UserActivityStudy:Triggers=EMPTY/Threshold=0.0/IdleTimeThreshold=5
EphemeralStorageStudy:Enabled
PermissionLifetimeStudy:Enabled

Screen Shot 2021-06-07 at 5 42 39 PM

@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2021

Verification passed on the following devices running 1.26.46 x64 build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants