New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RETRY_ON_NETWORK_CHANGE to referrals and stats #15034

Closed

kkuehlz opened this issue Mar 31, 2021 · 1 comment · Fixed by brave/brave-core#8396

Labels

feature/referral-promo OS/Android OS/Desktop priority/P1 QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Device-Types QA/Test-All-Platforms QA/Yes regression release-notes/exclude

Milestone

1.22.x - Release #5

Contributor

kkuehlz commented Mar 31, 2021 •

edited

Loading

Description

Followup to #15009. This will affect confirmations and custom headers. We also add the flag to stats requests because that may be affected too, as they ping the same host.

Steps to Reproduce

Boot the browser and custom headers and finalization may not occur on Android due to a network change

Reproduces how often:

Always on simulator, often on actual device

Brave version (info found on brave://version)

Version/Channel Information:

Can you reproduce this issue with the current release?
Y
Can you reproduce this issue with the beta channel?
Y
Can you reproduce this issue with the dev channel?
Y
Can you reproduce this issue with the nightly channel?
Y

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

kkuehlz added priority/P1 regression feature/referral-promo OS/Android QA/Yes labels

kkuehlz changed the title ~~Add RETRY_ON_NETWORK_CHANGE to referrals and stats~~ Add RETRY_ON_NETWORK_CHANGE to referrals

kkuehlz mentioned this issue

referrals: stats: Always RETRY_ON_NETWORK_CHANGE brave/brave-core#8396

Merged

24 tasks

kkuehlz pushed a commit to brave/brave-core that referenced this issue


          referrals: stats: Always RETRY_ON_NETWORK_CHANGE

2fd5f2e

Resolves brave/brave-browser#15034

kkuehlz changed the title ~~Add RETRY_ON_NETWORK_CHANGE to referrals~~ Add RETRY_ON_NETWORK_CHANGE to referrals and stats

kkuehlz closed this as completed in brave/brave-core#8396

kkuehlz pushed a commit to brave/brave-core that referenced this issue


          referrals: stats: Always RETRY_ON_NETWORK_CHANGE

0d38d1a

Resolves brave/brave-browser#15034

kkuehlz pushed a commit to brave/brave-core that referenced this issue


          referrals: stats: Always RETRY_ON_NETWORK_CHANGE

fb4cc82

Resolves brave/brave-browser#15034

kjozwiak added OS/Desktop QA/Test-All-Device-Types QA/Test-All-Platforms labels

kjozwiak modified the milestones: 1.24.x - Nightly, 1.22.x - Release #5

kkuehlz added the release-notes/exclude label

kjozwiak mentioned this issue

Android referrals not initializing correctly #15009

Closed

Member

kjozwiak commented Apr 1, 2021 •

edited by LaurenWags

Loading

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.22.71 Chromium: 89.0.4389.114

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used

Logs/Data from brave://local-state

"referral": {
         "download_id": "c60077e1-5419-401c-a2d4-5bc4719c03dc",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "referral_android_first_run_timestamp": "13261720590372766",
      "stats": {
         "first_check_made": true,
         "last_check_month": 3,
         "last_check_woy": 13,
         "last_check_ymd": "2021-03-31",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=android-bc&channel=release&version=1.22.71&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-03-31&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      }

Verification PASSED on Samsung Galaxy Tablet A running Android 10 using the following build:

1.22.71 Chromium: 89.0.4389.114

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used

Logs/Data from brave://local-state

"referral": {
         "download_id": "de30bc44-7dc4-4963-aa78-e8757ebaf31c",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "referral_android_first_run_timestamp": "13261721502043051",
      "stats": {
         "first_check_made": true,
         "last_check_month": 3,
         "last_check_woy": 13,
         "last_check_ymd": "2021-03-31",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=android-bc&channel=release&version=1.22.71&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-03-31&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      }

Verification passed on

Brave | 1.22.71 Chromium: 89.0.4389.114 (Official Build) (64-bit)
-- | --
Revision | 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS | Windows 10 OS Version 2004 (Build 19041.867)

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used

Logs/Data from brave://local-state

 "referral": {
         "download_id": "72fe67b4-18b1-4b82-863c-2fe16d4cb4c7",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "stats": {
         "first_check_made": true,
         "last_check_month": 4,
         "last_check_woy": 13,
         "last_check_ymd": "2021-04-01",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=winx64-bc&channel=release&version=1.22.71&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-04-01&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      }

Verification passed on

Brave	1.22.71 Chromium: 89.0.4389.114 (Official Build) (64-bit)
Revision	1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS	Ubuntu 18.04 LTS

Referrals are not supported on Linux so testing was limited

ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state

Logs/Data from brave://local-state

      "referral": {
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "BRV001"
      },
      "stats": {
         "first_check_made": true,
         "last_check_month": 4,
         "last_check_woy": 13,
         "last_check_ymd": "2021-04-01",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=linux-bc&channel=release&version=1.22.71&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-04-01&ref=BRV001&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      },

Verified passed with

Brave	1.22.71 Chromium: 89.0.4389.114 (Official Build) (arm64)
Revision	1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS	macOS Version 11.2.3 (Build 20D91)

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used

Logs/Data from brave://local-state

      "referral": {
         "download_id": "259abbe2-6acf-47fe-a285-570b04b6d844",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "stats": {
         "first_check_made": true,
         "last_check_month": 4,
         "last_check_woy": 13,
         "last_check_ymd": "2021-04-01",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=osxarm64-bc&channel=release&version=1.22.71&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-04-01&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"

Verified passed with

Brave | 1.22.71 Chromium: 89.0.4389.114 (Official Build) (x86_64)
-- | --
Revision | 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS | macOS Version 10.15.7 (Build 19H524)

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used

Logs/Data from brave://local-state

      "referral": {
         "download_id": "cee98c05-fbda-49cf-ac65-f56203598da0",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "stats": {
         "first_check_made": true,
         "last_check_month": 4,
         "last_check_woy": 13,
         "last_check_ymd": "2021-04-01",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=osx-bc&channel=release&version=1.22.71&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-04-01&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      },

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.22.71 Bravex86.apk.

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used

Logs/Data from brave://local-state

      "referral": {
         "download_id": "80d77015-b9d5-4a11-8516-a227799f1144",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "referral_android_first_run_timestamp": "13261777234949596",
      "stats": {
         "first_check_made": true,
         "last_check_month": 4,
         "last_check_woy": 13,
         "last_check_ymd": "2021-04-01",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=android-bc&channel=release&version=1.22.71&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-04-01&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      }
   },

kjozwiak added QA Pass - Android ARM QA Pass - Android Tab labels

GeetaSarvadnya added the QA Pass-Win64 label

btlechowski added OS/macOS OS/macOS-arm64 OS/Windows and removed OS/Windows OS/macOS labels

btlechowski added QA Pass-Linux and removed OS/macOS-arm64 labels

LaurenWags added QA Pass-macOS-arm64 QA Pass-macOS labels

kjozwiak mentioned this issue

Release notes for 1.22.x - Release #5 #15067

Closed

LaurenWags added the QA Pass - Android x86 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment