[Android] Request write permissions for stats sharing

[alexsafe]

Description

Not having the storage write permission already added results in a crash when trying to share stats

Steps to reproduce

1. Disable Storage permission (if it's set to Allow)
2. Navigate to a web page
3. Press the shields button and then the share icon or
   3.1 Wait for one the blocked ads+ trackers tier numbers to be hit and press the share button on the tooltip.

Actual result

The app crashes with a permission error

Expected result

If the write permission is not set the user should be presented with a request permission to allow storage write.
The flow of the stats share feature should not be interrupted and the app should not crash.
(We need storage write permission to temporary store the image containing the stats in order be share it)

Issue reproduces how often

Easily reproduced

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? No
• Can you reproduce this issue with the current Play Store Beta version? No
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Brave version

1.25.13

Website problems only

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards?N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Additional information

[srirambv]

@anthonypkeane Can you please confirm why the issue is marked as closed/by-author? Is this supposed to be checked on the build or can it be marked as QA/No?

[anthonypkeane]

Reopening as @alexsafe confirmed this needs to be QA'ed

[srirambv]

@anthonypkeane can't have open issues in the milestone unless its release blocking. @alexsafe can you confirm if the issue is fixed with brave/brave-core#8557?

Moving out of 1.25.x until confirmed. If this still needs to be fixed and should be part of 1.25.x need to have a PR done and get it uplifted to 1.25.x

cc: @kjozwiak @bsclifton

[kjozwiak]

Probably a good idea to recheck these as it was reverted from 1.25.x which is the channel most of the QA was done for this feature. Depending on a fix, this might go into a 1.25.x HF.

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.26.50 x64 Beta build

• Verified clicking on share button prompts for requesting access to storage

---

Verification passed on Samsung Tab A with Android 10 running 1.26.50 x64 Beta build

• Verified clicking on share button prompts for requesting access to storage

OnePlus 6T	Samsung Tab A

Logged follow up issue #16221