Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #8508 from brave/stats-social-sharing" #8938

Merged
merged 3 commits into from
May 27, 2021

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented May 26, 2021

Reverts stats social sharing feature for 1.25.x only. Reverts the following:

Moves the following issues to 1.26.x

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@alexsafe alexsafe requested a review from bsclifton May 26, 2021 20:26
@alexsafe alexsafe self-assigned this May 26, 2021
This reverts commit c5a792b, reversing
changes made to bcd9189.
…ats"

This reverts commit 05a5637, reversing
changes made to 10833fa.
This reverts commit c5443ff, reversing
changes made to 79aeb63.
@bsclifton bsclifton force-pushed the bsc-temp-revert-8505-sharing branch from b62a83a to 6fbfb98 Compare May 26, 2021 21:05
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton requested a review from a team May 26, 2021 21:17
@alexsafe alexsafe added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 26, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 1dde435 into 1.25.x May 27, 2021
@kjozwiak kjozwiak deleted the bsc-temp-revert-8505-sharing branch May 27, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants