Unable to download pdf instead opening them in brave. Unable to disable pdf.js via command line. #1531

Techguyprivate · 2018-10-11T17:58:46Z

Description

I always download pdf instead of opening them in browser. Going to content setting in chrome://setting , toggling the option to download pdf instaed of opening them, doesn't work.Pdf gets opened in browser. Unable to disable Pdf.js extension component via command line.No toggable option in extension setting .It is greyed out.

Steps to Reproduce

Go to chrome://setting.
Go to content setting.Then go to the option pdf document.
Toggle the option to download pdf instead of opening them in brave. Try to download any pdf file..

Actual result:

Pdf file is opening inside brave ,instead of getting downloaded.

Expected result:

Pdf file should be downloaded in brave, instead of opening inside the browser.

Reproduces how often:

Easily.

Brave version (chrome://version info)

Brave	0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision	cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS	Linux
JavaScript	V8 7.0.276.25
Flash	(Disabled)
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.45 Safari/537.36
Command Line	/usr/bin/brave-browser-beta --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor --flag-switches-begin --flag-switches-end
Executable Path	/opt/brave.com/brave-beta/brave-browser-beta
Profile Path	/home/anama/.config/BraveSoftware/Brave-Browser-

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds? Yes.
Does it reproduce on browser-laptop? No.

Website problems only:

Does the issue resolve itself when disabling Brave Shields? No.
Is the issue reproducible on the latest version of Chrome? No.

Additional Information

Remove any profile data.
Launch beta version with/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --show-component-extension-options
Navigate to chrome://extensions.

The text was updated successfully, but these errors were encountered:

rebron · 2018-11-13T19:40:59Z

@Techguyprivate is this still an issue in current release?

carn1x · 2018-11-14T05:57:48Z

I'm still unable to View PDFs in Version 0.55.22 Chromium: 70.0.3538.77 (Official Build) (64-bit). Setting Download PDF files instead of automatically opening them in Brave to True seems to make no difference PDF.js still seems try and show it in browser and gives invalid/corrupt error which other browsers (FF/Chrome) do not.

Techguyprivate · 2018-11-14T07:53:20Z

The issue is still there. .Still pdf not getting downloaded even when setting the option to " Download PDF files instead of automatically opening them in Brave " is set to true. Brave stable
Version 0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit).

Fixes brave/brave-browser#1531 The fix does the following: 1. Makes the initial decision on whether to load PDFJS extension based on the value of kPluginsAlwaysOpenPdfExternally profile preference. 2. Watches profile preference value kPluginsAlwaysOpenPdfExternally and adds/removes PDFJS extension when the value changes. 3. Modifies js behind the chrome://settings/content/pdfDocuments so that if the PDFJS extension is disabled from the command line the option to download PDF files instead of opening them in Brave is set to ON and the toggle is disabled. Note, that this fix doesn't address being able to turn off opening PDFs in Brave in Guest/Tor profiles. The web ui setting to do so is not available in these profiles. The command line switch to not load PDFJS already applies to all profile types.

Techguyprivate · 2018-11-29T04:34:08Z

#2267 #2267

alabamavtec · 2018-11-29T18:12:23Z

#2267

Also reproducible on Ubuntu 18.10 (64-bit):

`Brave	0.56.15 Chromium: 70.0.3538.110 (Official Build) (64-bit)
Revision	ca97ba107095b2a88cf04f9135463301e685cbb0-refs/branch-heads/3538@{#1094}
OS	Linux
JavaScript	V8 7.0.276.40
Flash	(Disabled)
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36
Command Line	/usr/bin/brave-browser --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor,AutofillSaveCardSignInAfterLocalSave,kAutofillServerCommunication --flag-switches-begin --flag-switches-end
Executable Path	/opt/brave.com/brave/brave-browser
Profile Path	/home/alabamavtec/.config/BraveSoftware/Brave-Browser/Default`

Setting does work, as expected (prompts download), in Chromium Browser version:
Version 70.0.3538.110 (Official Build)

Fixes brave/brave-browser#1531 The fix does the following: 1. Makes the initial decision on whether to load PDFJS extension based on the value of kPluginsAlwaysOpenPdfExternally profile preference in addition to the command line switch. 2. Watches profile preference value kPluginsAlwaysOpenPdfExternally and adds/removes PDFJS component when the value changes. 3. Modifies js behind the chrome://settings/content/pdfDocuments so that if the PDFJS extension is disabled from the command line the option to download PDF files instead of opening them in Brave is set to ON and the toggle is disabled. 4. Adds an alternative call for whitelisted extensions in extensions/common/manifest_handlers/mime_types_handler.h that removes Chrome's PDF Extension ID from whitelisted IDs and patches chrome/browser/plugins/plugin_utils.cc to use the alternative call. This is done because on Linux that extension is not removed from profile enabled extensions (because there is no extensions install verification) and it ends up being picked as a handler for PDFs. If our PDFJS extension is disabled via command line, this causes a PDF to be neither displayed nor downloaded. Note, that this fix doesn't address being able to turn off opening PDFs in Brave in Guest/Tor profiles. The web ui setting to do so is not available in these profiles. The command line switch to not load PDFJS already applies to all profile types. Adds browser tests to check that when the preference is set to always download or PDFJS is disabled from command line a download is initiated when navigating to a pdf url.

cndouglas · 2018-12-05T20:32:23Z

Related: #1778 (allow disabling PDF.js in settings)

Fixes brave/brave-browser#1531 The fix does the following: 1. Makes the initial decision on whether to load PDFJS extension based on the value of kPluginsAlwaysOpenPdfExternally profile preference in addition to the command line switch. 2. Watches profile preference value kPluginsAlwaysOpenPdfExternally and adds/removes PDFJS component when the value changes. 3. Modifies js behind the chrome://settings/content/pdfDocuments so that if the PDFJS extension is disabled from the command line the option to download PDF files instead of opening them in Brave is set to ON and the toggle is disabled. 4. Adds an alternative call for whitelisted extensions in extensions/common/manifest_handlers/mime_types_handler.h that removes Chrome's PDF Extension ID from whitelisted IDs and patches chrome/browser/plugins/plugin_utils.cc to use the alternative call. This is done because on Linux that extension is not removed from profile enabled extensions (because there is no extensions install verification) and it ends up being picked as a handler for PDFs. If our PDFJS extension is disabled via command line, this causes a PDF to be neither displayed nor downloaded. Note, that this fix doesn't address being able to turn off opening PDFs in Brave in Guest/Tor profiles. The web ui setting to do so is not available in these profiles. The command line switch to not load PDFJS already applies to all profile types. Adds browser tests to check that Chromium's PDF extension is not considered for handling PDFs and if the PDFJS extension is not loaded or disabled from command line a download is initiated when navigating to a PDF URL. Also adds test to verify that when PDF download preference is toggled the component loader will take an appropriate action (add or remove PDFJS extension).

btlechowski · 2019-01-02T22:16:31Z

Verification passed on

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows 7

Used Test plan from brave/brave-core#941
Used links:
https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
http://www.pdf995.com/samples/pdf.pdf

Verified passed with

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X

Verified manual test plan from Allow downloading PDFs instead of opening them in Brave. brave-core#941
Tested with these pdfs:
https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
http://www.pdf995.com/samples/pdf.pdf

srirambv · 2019-01-03T10:20:35Z

Verification only passed for manual enabling the switch in chrome://settings/content/pdfDocuments. Command line test failed on Linux due #1253 but based on #1253 (comment), ok to pass the test on Linux

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Linux

mkarolin · 2019-01-03T15:54:26Z

@srirambv, I tested on Mint 19 Cinnamon with the command line switch and navigating to a pdf link results in a download prompt.

rebron added extension/PDFJS feature/global-settings Settings at browser level independent of shields settings labels Oct 11, 2018

bsclifton changed the title ~~Unable to download pdf instaed opening them in brave. Unable to disable pdf.js via command line.~~ Unable to download pdf instead opening them in brave. Unable to disable pdf.js via command line. Oct 12, 2018

bbondy added this to the 1.x Backlog milestone Oct 16, 2018

bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 16, 2018

mkarolin self-assigned this Nov 19, 2018

mkarolin mentioned this issue Nov 21, 2018

Allow downloading PDFs instead of opening them in Brave. brave/brave-core#941

Merged

18 tasks

Techguyprivate mentioned this issue Nov 29, 2018

PDFs are still opened in-browser even though "Download PDF files instead of automatically opening them in Brave" is on #2267

Closed

cndouglas mentioned this issue Dec 5, 2018

Allow disabling the built-in PDF viewer #1778

Closed

mkarolin closed this as completed in brave/brave-core#941 Dec 14, 2018

mkarolin modified the milestones: 1.x Backlog, 0.59.x - Beta Dec 14, 2018

mkarolin added QA/Yes QA/Test-Plan-Specified labels Dec 14, 2018

bbondy added the release-notes/include label Dec 20, 2018

btlechowski added the QA Pass-Win64 label Jan 2, 2019

srirambv added the QA Pass-Linux label Jan 3, 2019

LaurenWags added the QA Pass-macOS label Jan 4, 2019

kjozwiak mentioned this issue Jan 31, 2019

Release notes for 0.59.x (Release Channel) #3173

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to download pdf instead opening them in brave. Unable to disable pdf.js via command line. #1531

Unable to download pdf instead opening them in brave. Unable to disable pdf.js via command line. #1531

Techguyprivate commented Oct 11, 2018

rebron commented Nov 13, 2018

carn1x commented Nov 14, 2018

Techguyprivate commented Nov 14, 2018

Techguyprivate commented Nov 29, 2018

alabamavtec commented Nov 29, 2018 •

edited

Loading

cndouglas commented Dec 5, 2018

btlechowski commented Jan 2, 2019 •

edited by LaurenWags

Loading

srirambv commented Jan 3, 2019

mkarolin commented Jan 3, 2019

Unable to download pdf instead opening them in brave. Unable to disable pdf.js via command line. #1531

Unable to download pdf instead opening them in brave. Unable to disable pdf.js via command line. #1531

Comments

Techguyprivate commented Oct 11, 2018

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (chrome://version info)

Reproducible on current release:

Website problems only:

Additional Information

rebron commented Nov 13, 2018

carn1x commented Nov 14, 2018

Techguyprivate commented Nov 14, 2018

Techguyprivate commented Nov 29, 2018

alabamavtec commented Nov 29, 2018 • edited Loading

cndouglas commented Dec 5, 2018

btlechowski commented Jan 2, 2019 • edited by LaurenWags Loading

srirambv commented Jan 3, 2019

mkarolin commented Jan 3, 2019

alabamavtec commented Nov 29, 2018 •

edited

Loading

btlechowski commented Jan 2, 2019 •

edited by LaurenWags

Loading