[Android] Crash on switching to existing rewards tab

[samartnik]

Description

There is intermittent crash on switching to existing rewards tab.

java.lang.IndexOutOfBoundsException: 
  at java.util.ArrayList.get (ArrayList.java:437)
  at org.chromium.ui.modelutil.ListModelBase.get (ListModelBase.java:33)
  at org.chromium.chrome.browser.tasks.tab_management.TabListModel.updateTabListModelIdForGroup (TabListModel.java:196)
  at org.chromium.chrome.browser.tasks.tab_management.TabListMediator$8.didMoveTabGroup (TabListMediator.java:840)
  at org.chromium.chrome.browser.tasks.tab_groups.TabGroupModelFilter.didMoveTab (TabGroupModelFilter.java:725)
  at org.chromium.chrome.browser.tabmodel.TabModelImpl.moveTab (TabModelImpl.java:251)
  at org.chromium.chrome.browser.app.BraveActivity.selectExistingTab (BraveActivity.java:739)
  at org.chromium.chrome.browser.app.BraveActivity.openNewOrSelectExistingTab (BraveActivity.java:753)
  at org.chromium.chrome.browser.BraveRewardsPanelPopup$5.onClick (BraveRewardsPanelPopup.java:321)

Steps to reproduce

I wasn't able to reproduce. Crash stack is taken from GPS.

Actual result

Intermittent crash

Expected result

No crash

Issue reproduces how often

Wasn't able to reproduce.

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version?
• Can you reproduce this issue with the current Play Store Beta version?
• Can you reproduce this issue with the current Play Store Nightly version?

Device details

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Brave version

Latest from GPS.

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[samartnik]

Test plan:

• Open rewards page from panel
• Go to a new page
• Try to open rewards page from panel (already opened page should be shown)

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.24.82 x64 build

• Verified test plan from [Android] Crash on switching to existing rewards tab #15389 (comment)
• Verified no crash when switching to rewards tab
• Verified focus is set to existing rewards tab even if its part of a tab group

---

Verification passed on Samsung Tab A with Android 10 running 1.24.82 x64 build

• Verified test plan from [Android] Crash on switching to existing rewards tab #15389 (comment)
• Verified no crash when switching to rewards tab