Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pref for disabling stats ping #16583

Closed
4 tasks
kkuehlz opened this issue Jun 24, 2021 · 3 comments · Fixed by brave/brave-core#9229
Closed
4 tasks

Add pref for disabling stats ping #16583

kkuehlz opened this issue Jun 24, 2021 · 3 comments · Fixed by brave/brave-core#9229

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Jun 24, 2021

Description

  • Create a preference for disabling the stats ping

Designs

  • Add usage ping toggle
  • Update text for P3A and Automatic crash reporting settings
  • Move crash reporting, usage ping, and P3A toggles to be closer to each other

image

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=808%3A7122

@kkuehlz kkuehlz added privacy priority/P2 A bad problem. We might uplift this to the next planned release. privacy/feature User-facing privacy- & security-focused feature work. OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 24, 2021
@kkuehlz kkuehlz self-assigned this Jun 24, 2021
kkuehlz pushed a commit to brave/brave-core that referenced this issue Jun 24, 2021
@kkuehlz
Copy link
Contributor Author

kkuehlz commented Jun 24, 2021

Test Plan

Prerequisites

Wireshark/Charrles Proxy/Etc

Steps

  1. Launch the browser. Using Wireshark ensure that usage ping is sent
  2. Go to settings and opt out of the usage ping. Restart browser
  3. Move time forward 1+ day and launch browser
  4. Ensure usage ping is not set
  5. Go to settings and opt into usage ping. Restart browser
  6. Ensure usage ping is sent.

@stephendonner
Copy link

stephendonner commented Jul 7, 2021

Verified PASSED using the inline testplan with build

Brave 1.28.60 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 12.0 (Build 21A5268h)

Steps:

  1. Launched Brave. Using Charles Proxy, ensured that usage ping is sent to laptop-updates.brave.com.
  2. Went to brave://settings and opted out of the usage ping. Restarted Brave.
  3. Moved time forward 1+ day and launched Brave.
  4. Ensured usage ping was not sent, via Charles Proxy.
  5. Went to brave://settings and opted into usage ping. Restarted Brave.
  6. Ensured usage ping was sent, via Charles Proxy
step 1 step 4 step 6
Screen Shot 2021-07-07 at 4 24 31 PM Screen Shot 2021-07-08 at 4 27 47 PM Screen Shot 2021-07-08 at 4 29 20 PM

Verification passed on

Brave | 1.28.91 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
-- | --
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | Windows 10 OS Version 2004 (Build 19041.1110)

Verified the description from the issue #16583 (comment)
Verified the test plan from #16583 (comment)

Confirmed that the setting Automatically send daily usage ping to Brave is been added in brave://settings/privacy page
image

  • Launched brave and ensured that usage ping is sent to laptop-updates.brave.com.
    image

  • Turned OFF the settings Automatically send daily usage ping to Brave in brave://settings/privacy and restarted the browser and moved the system time to 24 hours, and then launched browser and ensured usage ping is NOT set in Charles proxy
    image

  • Turned ON the settings Automatically send daily usage ping to Brave in brave://settings/privacy and restarted the browser and ensured that usage ping is sent to laptop-updates.brave.com
    image


Verification passed on

Brave 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS Ubuntu 18.04 LTS

Verified the description from the issue #16583 (comment)
Verified the test plan from #16583 (comment)

Confirmed that the setting Automatically send daily usage ping to Brave is been added in brave://settings/privacy page
image

  • Launched brave and ensured that usage ping is sent to laptop-updates.brave.com.
    image

  • Turned OFF the settings Automatically send daily usage ping to Brave in brave://settings/privacy and restarted the browser and moved the system time to 24 hours, and then launched browser and ensured usage ping is NOT set in Charles proxy

image image
  • Turned ON the settings Automatically send daily usage ping to Brave in brave://settings/privacy and restarted the browser and ensured that usage ping is sent to laptop-updates.brave.com
image image

@srirambv
Copy link
Contributor

@keur There is no UI Setting for this change on Android. I added Android specific implementation issue #17158, also removing Android label from this one

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jul 26, 2021
@rebron rebron changed the title Create pref for disabling stats ping Add pref for disabling stats ping Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants