Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silent installer is failed on x86 when there is no BraveSoftware\Promo registry key #1695

Closed
simonhong opened this issue Oct 18, 2018 · 1 comment · Fixed by brave/brave-core#1049
Closed

silent installer is failed on x86 when there is no BraveSoftware\Promo registry key #1695

simonhong opened this issue Oct 18, 2018 · 1 comment · Fixed by brave/brave-core#1049
Assignees
@simonhong
Labels
OS/Windows priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@simonhong
Copy link
Member

simonhong commented Oct 18, 2018 •
edited
Loading

Reproduce steps

  1. Delete HKEY_CURRENT_USER\Software\BraveSoftware\Promo if exists
  2. Run brave_installer.exe on x86 windows platform
@simonhong simonhong self-assigned this Oct 18, 2018
@simonhong simonhong mentioned this issue Oct 18, 2018
Closed
@simonhong simonhong added this to the 1.x Backlog milestone Oct 26, 2018
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". OS/Windows labels Nov 2, 2018
@simonhong simonhong mentioned this issue Dec 10, 2018
Merged
18 tasks
@simonhong simonhong modified the milestones: 1.x Backlog, 0.60.x - Nightly Dec 10, 2018
@kjozwiak kjozwiak mentioned this issue Feb 15, 2019
Closed
@btlechowski
Copy link

Verification passed on

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (32-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

Each time used fresh Windows 7 32 bit VM.
Tested all the installers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Windows priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix brave_installer.exe fail on x86 brave/brave-core
4 participants
@bbondy @rebron @simonhong @btlechowski