Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DHT client in WebTorrent for supporting trackless torrents #857

Closed
yrliou opened this issue Aug 27, 2018 · 2 comments · Fixed by brave/brave-core#443
Closed

Enable DHT client in WebTorrent for supporting trackless torrents #857

yrliou opened this issue Aug 27, 2018 · 2 comments · Fixed by brave/brave-core#443

Comments

@yrliou
Copy link
Member

yrliou commented Aug 27, 2018

In bittorrent-dht, it's using nodejs's dns.lookup, we should provide our own shim to use chromium's existing API or implemented one if none exists.

@yrliou yrliou added the feature/webtorrent Label for webtorrent related issues label Aug 27, 2018
@bbondy bbondy added this to the Backlog milestone Aug 29, 2018
@yrliou yrliou changed the title Support of trackless torrents using bittorrent-dht/client Enable DHT client in WebTorrent for supporting trackless torrents Sep 12, 2018
@yrliou yrliou self-assigned this Sep 12, 2018
@yrliou yrliou modified the milestones: 1.x Backlog, Releasable builds 0.55.x Sep 12, 2018
@yrliou
Copy link
Member Author

yrliou commented Sep 27, 2018

QA note: See brave/brave-core#443 for the test plan.

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2018

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux and Windows
  • Verified webtorrent is loaded and able to connect to peers and download the file

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants