Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave web3 + MetaMask extension not working #17168

Closed
jcp3alex opened this issue Jul 26, 2021 · 25 comments · Fixed by brave/brave-core#10191
Closed

Brave web3 + MetaMask extension not working #17168

jcp3alex opened this issue Jul 26, 2021 · 25 comments · Fixed by brave/brave-core#10191
Labels
feature/ethereum-remote-client feature/extensions OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.31.x - Release

Comments

@jcp3alex
Copy link

Ever since the update to V1.27.108 MetaMask fails to connect to web3 websites on Brave browser. Up until today, I was able to get it working by uninstalling the addon and re-installing the addon, but today that doesn't work any longer. Sometimes I will get a Metamask pop-up, independent of the addon that I can sign in to, but it happens randomly. I have tried re-installing after I shut down my PC, but that doesn't work either,
@bsclifton bsclifton added feature/extensions feature/web3/wallet Integrating Ethereum+ wallet support labels Jul 27, 2021
@mxwlsavard
Copy link

Same experience here. MetaMask shows a message about the window.web3 API being removed form the add-on but that's not the issue. I found more discussion on the issue here: https://community.brave.com/t/metamask-stop-working-with-brave-browser/269031/11

I hope this gets some priority because MetaMask can't connect to any web3 site right now as far as I can tell.

@Tonev
Copy link
Contributor

Tonev commented Aug 3, 2021

A lot of complaints regarding MetaMask in Community.

In one of the threads, a user (Luckys) shared a workaround that worked for a few users.

Hi managed to sort mine by going into Brave settings and turning off (Load crypto wallets on startup) then restarting browser hope this may help some of you.

it worked for some of us try it!

Community thread:
https://community.brave.com/t/metamask-stop-working-with-brave-browser/269031

@isim95
Copy link

isim95 commented Aug 11, 2021

Can confirm that this worked for me - thank you Tonev for the fix. Hopefully this solve will work for all others with this issue as well

A lot of complaints regarding MetaMask in Community.

In one of the threads, a user (Luckys) shared a workaround that worked for a few users.

Hi managed to sort mine by going into Brave settings and turning off (Load crypto wallets on startup) then restarting browser hope this may help some of you.
it worked for some of us try it!

Community thread:
https://community.brave.com/t/metamask-stop-working-with-brave-browser/269031

@bbondy bbondy mentioned this issue Sep 22, 2021
Merged
24 tasks
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
@bbondy bbondy added this to the 1.32.x - Nightly milestone Sep 23, 2021
@brave-builds brave-builds mentioned this issue Sep 23, 2021
Merged
7 tasks
@LaurenWags LaurenWags added feature/web3/wallet Integrating Ethereum+ wallet support QA/Test-All-Platforms labels Sep 28, 2021
@srirambv
Copy link
Contributor

srirambv commented Oct 1, 2021

Verification passed on

Brave 1.31.67 Chromium: 94.0.4606.61 (Official Build) beta (x86_64)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS macOS Version 11.5.2 (Build 20G95)
  • Verified there is no option for Load crypto wallet on startup
  • Verified when MM is installed, default provider is set to MM with or without flag being enabled
image image

Verification passed on

Brave 1.31.67 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS Windows 11 Version Dev (Build 22468.1000)
  • Verified there is no option for Load crypto wallet on startup
  • Verified when MM is installed, default provider is set to MM with or without flag being enabled
image image

Verification passed on

Brave 1.31.67 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS Linux
  • Verified there is no option for Load crypto wallet on startup
  • Verified when MM is installed, default provider is set to MM with or without flag being enabled
image image

@srirambv srirambv added QA Pass-Linux QA Pass-macOS QA Pass-Win64 and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Oct 1, 2021
@kjozwiak kjozwiak mentioned this issue Oct 19, 2021
Closed
@Billyv1
Copy link

Billyv1 commented Oct 19, 2021

Greetings,
My MetaMask extension was working just fine in Brave Browser with web3 sites until I got hit with the new V1.31.87 (Oct 19, 2021) today. Now web3 sites are not working, I can't connect with MetaMask and log into my account on these sites, like Rarible.com using my MetaMask. MetaMask wallet is no longer an option, even though if I just log into MetaMask and it shows my wallet is connected to that site. Also if I'm not logged into MetaMask and I select "Connect Wallet" on the web3 site, the "Crypto Wallet" login pops up instead of the MetaMask login pop up.

@srirambv
Copy link
Contributor

@Billyv1 what is the default provider set to?

@Billyv1
Copy link

Billyv1 commented Oct 20, 2021 via email

@srirambv
Copy link
Contributor

No what is Default cryptocurrency wallet provider set to?
image

@Billyv1
Copy link

Billyv1 commented Oct 20, 2021 via email

@vinzentg
Copy link

Hi,

Everything has been working fine since early August but since a few days ago I can't connect Metamask to my Ledger Nano S through Brave. It does not trigger any action and that previously annoying "Making sure it's you" windows security pop-up does not pop either.
Brave Please get back to me how this can be fixed?

@bbondy
Copy link
Member

bbondy commented Oct 22, 2021

MetaMask requires you to use Ledger Live for Ledger support. But I believe they're improving that now. We support Ledger without Ledger Live fwiw.

@rjaym
Copy link

rjaym commented Jul 7, 2022

Bumping as you guys need to resolve this. Plenty of MetaMask users on Brave.
MetaMask 10.16.1 is not working for all the defi sites I was previously just a month or so ago. This is Brave [Version 1.40.113 Chromium: 103.0.5060.114 (Official Build) (64-bit)]

@srirambv
Copy link
Contributor

@rjaym mind adding an example where it's failing or adding more detailed steps? I ran through MM on current nightly and it worked fine with a bunch of sites.

@rjaym
Copy link

rjaym commented Jul 10, 2022

@rjaym mind adding an example where it's failing or adding more detailed steps? I ran through MM on current nightly and it worked fine with a bunch of sites.

I am unable to use your nightly builds.

@rjaym
Copy link

rjaym commented Jul 10, 2022

@rjaym mind adding an example where it's failing or adding more detailed steps? I ran through MM on current nightly and it worked fine with a bunch of sites.

Also, sorry there really are no detailed steps or special setup as far as I know, it's just Brave on Windows 10 and MM with the versions stated above, although I am using the Avalanche network and not Ethereum.

@srirambv
Copy link
Contributor

Ok thanks for the update. I'll give it a try on Avalanche network. Any specific Defi sites that you are facing problems with?

@rjaym
Copy link

rjaym commented Jul 10, 2022

Ok thanks for the update. I'll give it a try on Avalanche network. Any specific Defi sites that you are facing problems with?

All defi sites, they show connected in MM with a green status icon, but the site itself shows as disconnected to MM. Also yes I have tried changing the "Default cryptocurrency wallet" option many times (all options) but nothing has allowed the sites to understand that MM is installed and connected. All the defi sites prompt me to connect to a wallet as if MM is not installed.

@bbondy
Copy link
Member

bbondy commented Jul 12, 2022

If you're changing between wallets you might want to clear cookies on the site in question

@andrewvink
Copy link

andrewvink commented Jul 12, 2022 •
edited
Loading

Not working for me either - updated Brave too, but still doesn't connect. Works on Chrome but not Brave

MetaMask - Version - 10.16.2
Brave - Version 1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)]

@rjaym
Copy link

rjaym commented Jul 13, 2022

If you're changing between wallets you might want to clear cookies on the site in question

I cleared cookies to no avail. The only other hint I can come up with at this time is that it appeared that MM may have updated (automatically as usual?) after which the defi sites would no longer connect. I think I recall getting the MM notification/hint (because I think MM autoupdated as stated) that I could turn on dark mode, which I did, after which the issue began.

@bbondy
Copy link
Member

bbondy commented Jul 13, 2022

Not working for me either - updated Brave too, but still doesn't connect. Works on Chrome but not Brave

MetaMask - Version - 10.16.2 Brave - Version 1.41.96 Chromium: 103.0.5060.114 (Official Build) (64-bit)]

What is your "default wallet" set to in brave://settings/wallet ?
What happens when you try to connect? Does Brave Wallet come up or MetaMask?

@bbondy
Copy link
Member

bbondy commented Jul 13, 2022

fwiw I've deeply investigated dozens of these types of reports and every time it ends up being that there are multiple wallet extensions installed that are competing for window.ethereum and causing problems with each other. The claims that it works in Chrome is because the same set of extensions aren't installed on Chrome.

I'm still willing to investigate further, but for the past couple years I believe every investigation has led to no real issue.

Setting your wallet to None in brave://settings/wallet will make it so Brave does not try to insert window.ethereum at all.
Setting it to Brave Wallet (Prefer extensions) makes it so Brave does insert window.ethereum but allows it to be overwritten.

@andrewvink
Copy link

@bbondy thanks for the reply!

Checking my "default wallet" was the first thing I did - it is set as 'NONE' - but still having the issue.

Cleared all cache, cookies, site data, hosted app data in Brave ( Clear Browsing Data - All Time )

When going to Pancake Swap ( https://pancakeswap.finance/ ) for example the site loads - as soon as I click "connect wallet", the screen goes black and inspecting I can see a number of errors in the console.

The one that sticks out the most based on your other 2nd comment was:
MetaMask: 'ethereum.send(...)' is deprecated and may be removed in the future. Please use 'ethereum.sendAsync(...)' or 'ethereum.request(...)' instead.
For more information, see: https://eips.ethereum.org/EIPS/eip-1193

Pancake Swap - Screenshot:
https://i.imgur.com/ny8yNvX.png

On a separate DAPP similar thing happens - click on 'Connect Wallet' - screen turns black, this time if I inspect no ethereum error
https://i.imgur.com/LQhrnku.png

Thanks for reading! 🙏🏼

@rjaym
Copy link

rjaym commented Jul 19, 2022

An update, I ended up uninstalling the MM extension and reinstalling and now it is working again after I importing my old wallet using the 12 word recovery phrase.
This implies some LocalStorage or cached data from the extension itself was causing an issue. Unfortunately, the workaround can be quite cumbersome.
I am still not sure where the blame should lie though to be honest, MM or Brave, it's unclear.

@bbondy
Copy link
Member

bbondy commented Jul 19, 2022

Honestly the MM is extension is sometimes just buggy. What makes it worse is that other extensions often conflict with it as they compete fro window.ethereum. There is absolutely no logic specific to MetaMask in Brave so Brave works the same as Chromium and Chrome. Now if you go and try on Chrome, you have a new profile so you might not reproduce. Just like if you use Brave and create a new profile you probably won't reproduce as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/ethereum-remote-client feature/extensions OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.31.x - Release