Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave://about missing Brave-specific URLs #17299

Closed
da2x opened this issue Aug 2, 2021 · 2 comments · Fixed by brave/brave-core#9785
Closed

brave://about missing Brave-specific URLs #17299

da2x opened this issue Aug 2, 2021 · 2 comments · Fixed by brave/brave-core#9785
Assignees
@nullhook
Labels
good first issue OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.30.x - Release

Comments

@da2x
Copy link

da2x commented Aug 2, 2021

Steps to Reproduce

  1. Open brave://about

Expected result:

The page should include:

  • brave://ipfs-internals
  • brave://adblock
  • …others?

Actual result:

The page doesn’t include these URLs.

Reproduces how often:

Every time.

Brave version (brave://version info)

1.27.109 Chromium: 92.0.4515.115
@da2x da2x added the OS/Desktop label Aug 2, 2021
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. good first issue labels Aug 6, 2021
@SebastianLF
Copy link

Can i work on this one ?

@nullhook nullhook self-assigned this Aug 18, 2021
@nullhook nullhook mentioned this issue Aug 18, 2021
Merged
24 tasks
@nullhook nullhook added this to the 1.30.x - Nightly milestone Aug 25, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.30.56 Chromium: 93.0.4577.58 (Official Build) beta (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://about
  4. looked at the listed URLs

Confirmed both brave://adblock and brave://ipfs-internals were now listed.

example example example
Screen Shot 2021-08-30 at 2 28 59 PM Screen Shot 2021-08-30 at 2 29 08 PM Screen Shot 2021-08-30 at 2 29 34 PM

@LaurenWags LaurenWags mentioned this issue Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
good first issue OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

added brave product urls to brave://about brave/brave-core
5 participants
@stephendonner @da2x @rebron @SebastianLF @nullhook