Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Widevine in Tor mode #1076

Open
bsclifton opened this issue Sep 10, 2018 · 5 comments
Open

Disable Widevine in Tor mode #1076

bsclifton opened this issue Sep 10, 2018 · 5 comments
Labels
browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#13626

@bsclifton bsclifton added feature/tor feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. labels Sep 10, 2018
@bsclifton bsclifton added this to the 1.x Backlog milestone Sep 10, 2018
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 30, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@kjozwiak
Copy link
Member

Still an issue, easiest way to reproduce, see the issue occurring:

You'll notice that you'll get a Widevine notification and can install it inside a Tor Window. Example:

installingwidevinetor

@riastradh-brave riastradh-brave added the needs-investigation A bug not 100% confirmed/fixed label Jul 25, 2019
@iefremov
Copy link
Contributor

Blocking the Widevine installation prompt is trivial, we have just to add a check for Tor profile in BraveDrmTabHelper::OnWidevineKeySystemAccessRequest. Do we also have to block playing Widevine videos in Tor windows if Widevine is already installed? @diracdeltas @bsclifton

@diracdeltas
Copy link
Member

i think we should not allow widevine in tor mode even if already installed (same with flash if its installed) but defer to @tomlowenthal

@tildelowengrimm
Copy link
Contributor

I agree with @diracdeltas on this one. My preference is to disable Widevine entirely in Tor: no prompt to install, and no playing if it's already installed.

@iefremov
Copy link
Contributor

No playing goal should be achievable by disabling the content setting for plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

8 participants