Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out rb_clickid from URLs #17451

Closed
fmarier opened this issue Aug 12, 2021 · 3 comments · Fixed by brave/brave-core#9733
Closed

Filter out rb_clickid from URLs #17451

fmarier opened this issue Aug 12, 2021 · 3 comments · Fixed by brave/brave-core#9733
Assignees

Comments

@fmarier
Copy link
Member

fmarier commented Aug 12, 2021

rb_clickid was added as a tracking parameter in jparise/chrome-utm-stripper#44, but it's very hard to find any information about it (note that we should leave linkid alone for webcompat reasons).

It's used all over the place on Russian sites, for example:

https://veryberrylab.ru/catalog/bukety-s-klubnikoy/?rb_clickid=86252549-1618003652-1663225310&size=1&price_from=3000&price_to=5000

A lot of Russian websites also exclude it in their robots.txt, for example https://esh-derevenskoe.ru/robots.txt.

The TopMailRu tracker does seem to use it, though their minified code is especially hard to decipher.

The only blog post I could find about it only mentions that it's often seen in combination with utm_source=mytarget though the example above shows that it's not always the case.

Based on its name and the fact that it's high-entropy, we should assume that this is tracking users as opposed to campaigns.

@fmarier fmarier added privacy priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Aug 12, 2021
@fmarier fmarier self-assigned this Aug 12, 2021
fmarier added a commit to brave/brave-core that referenced this issue Aug 12, 2021
@fmarier fmarier added this to the 1.30.x - Nightly milestone Aug 12, 2021
@stephendonner
Copy link

@fmarier mind providing a simplified testcase? (I just want to be sure we don't miss anything.) Thanks!

@stephendonner
Copy link

Verified PASSED using the testplan at brave/brave-core#9733 with build

Brave 1.30.27 Chromium: 92.0.4515.159 (Official Build) nightly (x86_64)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launch Brave
  3. opened Developer Tools, clicked on the Network panel
  4. loaded https://brave.com/?rb_clickid=1234567890abcdef
  5. confirmed that the redirected page loaded doesn't contain the rb_clickid= parameter

Screen Shot 2021-08-17 at 8 53 19 AM

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 11 running 1.30.76 x64 build


Verification passed on Samsung Tab A with Android 11 running 1.30.76 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants