Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't remove keys from brave://settings/ipfs/keys #17484

Closed
kjozwiak opened this issue Aug 13, 2021 · 3 comments · Fixed by brave/brave-core#9897
Closed

can't remove keys from brave://settings/ipfs/keys #17484

kjozwiak opened this issue Aug 13, 2021 · 3 comments · Fixed by brave/brave-core#9897

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Aug 13, 2021

Description

When attempting to remove either imported or generated keys from brave://settings/ipfs/keys, you'll get the following error:

[3048:24972:0813/185341.263:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Unable to remove key", source: chrome://settings/ipfs/keys (0)

@stephendonner also reproduced on macOS.

Steps to Reproduce

  1. launch brave and go to brave://settings/ipfs
  2. change Method to resolve IPFS resources to Local Node
  3. you should see Set up your IPNS keys appear at the bottom of the IPFS settings
  4. click on Set up your IPNS keys
  5. add a new key by either generating a new one or importing a previous one
  6. attempt to remove keys via the Remove button under the kabob menu next to each key

Actual result:

Clicking on Remove under brave://settings/ipfs/keys doesn't remove keys (either generated or imported)

Expected result:

Users should be able to remove keys from brave://settings/ipfs/keys without any issues/errors

Reproduces how often:

100% reproducible using the STR mentioned above.

Brave version (brave://version info)

Brave | 1.30.21 Chromium: 92.0.4515.131 (Official Build) nightly (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19042.1165)
Brave | 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19042.1165)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @spylogsster @StephenBass

@stephendonner
Copy link

Verified PASSED using

Brave 1.31.8 Chromium: 93.0.4577.58 (Official Build) nightly (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launched Brave
  3. went to brave://settings/ipfs
  4. changed Method to resolve IPFS resources to Local Node
  5. you should see Set up your IPNS keys appear at the bottom of the IPFS settings
  6. click on Set up your IPNS keys
  7. add a new key by either generating a new one or importing a previous one
  8. attempt to remove keys via the Remove button under the kabob menu next to each key

Confirmed I could remove imported, generated, and rotated keys

example example example
Screen Shot 2021-08-30 at 3 15 00 PM Screen Shot 2021-08-30 at 3 15 13 PM Screen Shot 2021-08-30 at 3 15 20 PM

@stephendonner
Copy link

As this reproduces in 1.30.x, can we get this fix uplifted, @spylogsster?

@spylogsster
Copy link

As this reproduces in 1.30.x, can we get this fix uplifted, @spylogsster?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment