Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setting to disable the chrome sharing hub #17548

Closed
anthonypkeane opened this issue Aug 18, 2021 · 3 comments · Fixed by brave/brave-core#10248
Closed

Implement setting to disable the chrome sharing hub #17548

anthonypkeane opened this issue Aug 18, 2021 · 3 comments · Fixed by brave/brave-core#10248
Assignees
@samartnik
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.31.x - Release

Comments

@anthonypkeane
Copy link

Description

A user left some great feedback here pertaining to sharing hub.

He wants a way to disable the "chrome sharing hub" and replace it with Android's default sharing window.

Please implement a setting to disable "chrome sharing hub"

In Appearance, under Enable Tab Groups add

Enable Android sharing window
Defaulted to Off

cc @karenkliu and @jamesmudgett for views.
@anthonypkeane anthonypkeane added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality labels Aug 18, 2021
@alexsafe alexsafe self-assigned this Aug 18, 2021
@samartnik samartnik self-assigned this Sep 24, 2021
@samartnik
Copy link
Contributor

As per slack discussion, option will be named Disable Sharing Hub

@bsclifton bsclifton added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 24, 2021
@bsclifton
Copy link
Member

Bumped up to P2 since we would uplift this when a fix is available (work in progress by @samartnik 😄)

@samartnik samartnik mentioned this issue Sep 24, 2021
Merged
24 tasks
@samartnik samartnik added this to the 1.32.x - Nightly milestone Sep 24, 2021
@srirambv
Copy link
Contributor

srirambv commented Oct 7, 2021

Verification passed on Oppo Reno 5 with Android 11 running 1.31.74 x64 Beta build

  • Verified new setting Disable Sharing Hub is available under Appearnce
  • Verified default state for the setting is off
  • Verified when the setting is enabled, share button brings share sheet instead of Google Share hub
Setting Disabled (Default) Setting Enabled Share Sheet when disabled Google Share hub when enabled
image image image image

Verification failed on Samsung Tab A with Android 10 running 1.31.74 x64 Beta build. Logged #18612

@kjozwiak kjozwiak mentioned this issue Nov 2, 2021
Closed
@reactorcoremeltdown reactorcoremeltdown mentioned this issue Dec 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Added option to disable sharing hub brave/brave-core
6 participants
@kjozwiak @bsclifton @alexsafe @anthonypkeane @srirambv @samartnik