Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Added option to disable sharing hub #10248

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Sep 24, 2021

Resolves brave/brave-browser#17548

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 24, 2021
@samartnik samartnik added this to the 1.32.x - Nightly milestone Sep 24, 2021
@samartnik samartnik self-assigned this Sep 24, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit a679199 into master Sep 24, 2021
@samartnik samartnik deleted the android_disable_sharing_hub branch September 24, 2021 21:43
@samartnik samartnik restored the android_disable_sharing_hub branch September 24, 2021 21:49
@samartnik samartnik deleted the android_disable_sharing_hub branch September 24, 2021 21:57
@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2021

Verification passed on Oppo Reno 5 with Android 11 running 1.32.46 x64 Nightly build

  • Verified new setting is available under appearance
  • Verified changing switch state doesn't prompt for a restart
  • Verified when switch is disabled shows Google share hub
  • Verified when switch is enabled shows normal share sheet
  • Verified default state for the new setting is disabled
Setting Disabled (Default) Setting Enabled Share Sheet when disabled Google Share hub when enabled
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement setting to disable the chrome sharing hub
3 participants