Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr94] Android build fails on python2_action #17809

Closed
AlexeyBarabash opened this issue Sep 1, 2021 · 0 comments
Closed

[cr94] Android build fails on python2_action #17809

AlexeyBarabash opened this issue Sep 1, 2021 · 0 comments
Assignees
@AlexeyBarabash
Labels
closed/no-milestone OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude

Comments

@AlexeyBarabash
Copy link
Contributor

Running Android build fails with

ERROR at //brave/app/android/BUILD.gn:4:1: Unknown function.
python2_action("generate_breakpad_symbols") {
^-------------
See //brave/BUILD.gn:365:5: which caused the file to be included.
    "app/$current_os:symbol_dist_resources",
    ^--------------------------------------

Relative Chromium change https://chromium.googlesource.com/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee
@AlexeyBarabash AlexeyBarabash added the OS/Android Fixes related to Android browser functionality label Sep 1, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Sep 1, 2021
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Sep 1, 2021
@AlexeyBarabash
Update python version to 3 for tools/android/generate_breakpad_symbol…
a4b274a 
…s.py

fixes brave/brave-browser#17809

Related Chromium change https://source.chromium.org/chromium/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee :

build: remove is_python2.py

_is_python2 is always false now.

Bug: 1112471
Change-Id: I049610e59c7f51472b6326a7fcdd82c732725cec
@AlexeyBarabash AlexeyBarabash mentioned this issue Sep 1, 2021
Merged
24 tasks
mariospr pushed a commit to brave/brave-core that referenced this issue Sep 3, 2021
@AlexeyBarabash @mariospr
Update python version to 3 for tools/android/generate_breakpad_symbol…
187eba2 
…s.py

fixes brave/brave-browser#17809

Related Chromium change https://source.chromium.org/chromium/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee :

build: remove is_python2.py

_is_python2 is always false now.

Bug: 1112471
Change-Id: I049610e59c7f51472b6326a7fcdd82c732725cec
mkarolin pushed a commit to brave/brave-core that referenced this issue Sep 7, 2021
@AlexeyBarabash @mkarolin
Update python version to 3 for tools/android/generate_breakpad_symbol…
e22e43b 
…s.py

fixes brave/brave-browser#17809

Related Chromium change https://source.chromium.org/chromium/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee :

build: remove is_python2.py

_is_python2 is always false now.

Bug: 1112471
Change-Id: I049610e59c7f51472b6326a7fcdd82c732725cec
mkarolin pushed a commit to brave/brave-core that referenced this issue Sep 11, 2021
@AlexeyBarabash @mkarolin
Update python version to 3 for tools/android/generate_breakpad_symbol…
69f20f8 
…s.py

fixes brave/brave-browser#17809

Related Chromium change https://source.chromium.org/chromium/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee :

build: remove is_python2.py

_is_python2 is always false now.

Bug: 1112471
Change-Id: I049610e59c7f51472b6326a7fcdd82c732725cec
mkarolin pushed a commit to brave/brave-core that referenced this issue Sep 13, 2021
@AlexeyBarabash @mkarolin
Update python version to 3 for tools/android/generate_breakpad_symbol…
dcae460 
…s.py

fixes brave/brave-browser#17809

Related Chromium change https://source.chromium.org/chromium/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee :

build: remove is_python2.py

_is_python2 is always false now.

Bug: 1112471
Change-Id: I049610e59c7f51472b6326a7fcdd82c732725cec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
closed/no-milestone OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexeyBarabash